-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #136 UI design mismatch fix bug #138
Conversation
Current Code Coverage Percent of this PR:68.4 %Files having coverage below 100%
|
78338f3
to
8585a68
Compare
5749bbf
to
29c8344
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aniket-k-kaushik Move all the placeholder text to en.yml. Rest LGTM.
Also, can you add a hover in the edit and delete icon. Currently, the clicking experience is too bad.
done @akhilgkrishnan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LKTM for issue #136
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Fixes #136
Fixes #122
Pull Request Template
Description
Bug:
Team Index page Create New User Modal,
Changed the font design, fixed Modal Max width, added hover effect in the close button, add placeholder, made default value of role to employee, hand icon on role when hover over it.
Letter spacing of table headers & invitation pending tags fixed
Fixes # (issue)
Type of change
Please delete options that are not relevant.
not work as expected)
How Has This Been Tested?
Checklist: