Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #136 UI design mismatch fix bug #138

Merged
merged 12 commits into from
Feb 9, 2022

Conversation

aniketkaushik
Copy link
Contributor

@aniketkaushik aniketkaushik commented Feb 9, 2022

Fixes #136
Fixes #122

Pull Request Template

Description

Bug:
Team Index page Create New User Modal,
Changed the font design, fixed Modal Max width, added hover effect in the close button, add placeholder, made default value of role to employee, hand icon on role when hover over it.
Letter spacing of table headers & invitation pending tags fixed

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

Screenshot from 2022-02-09 18-31-26

@vipulnsward vipulnsward temporarily deployed to miru-review-pr-138 February 9, 2022 11:21 Inactive
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Current Code Coverage Percent of this PR:

68.4 %

Files having coverage below 100%

Impacted Files Coverage
/config/routes.rb 94.74 %
/app/models/user.rb 80.0 %
/app/controllers/projects_controller.rb 50.0 %
/app/controllers/application_controller.rb 77.78 %
/app/helpers/application_helper.rb 80.0 %
/app/helpers/team_helper.rb 57.14 %
/app/controllers/time_tracking_controller.rb 30.0 %
/app/controllers/concerns/timesheet.rb 37.5 %
/app/controllers/company_controller.rb 67.65 %
/app/controllers/root_controller.rb 33.33 %
/app/controllers/team_controller.rb 38.46 %
/app/controllers/dashboard_controller.rb 66.67 %
/app/controllers/clients_controller.rb 66.67 %
/app/controllers/concerns/error_handler.rb 60.0 %
/app/models/timesheet_entry.rb 81.25 %
/app/controllers/users/passwords_controller.rb 41.67 %
/app/controllers/users/omniauth_callbacks_controller.rb 25.0 %
/app/controllers/users/sessions_controller.rb 25.0 %
/app/controllers/users/registrations_controller.rb 45.83 %
/app/controllers/users/invitations_controller.rb 63.64 %
/app/controllers/internal_api/v1/application_controller.rb 85.71 %
/app/controllers/internal_api/v1/timesheet_entry_controller.rb 35.71 %

@aniketkaushik aniketkaushik requested a review from mohinid February 9, 2022 11:23
@aniketkaushik aniketkaushik self-assigned this Feb 9, 2022
@aniketkaushik aniketkaushik force-pushed the ui-design-mismatch-fix-bug branch from 78338f3 to 8585a68 Compare February 9, 2022 12:23
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-138 February 9, 2022 12:24 Inactive
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-138 February 9, 2022 12:28 Inactive
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-138 February 9, 2022 12:49 Inactive
@aniketkaushik aniketkaushik force-pushed the ui-design-mismatch-fix-bug branch from 5749bbf to 29c8344 Compare February 9, 2022 13:01
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-138 February 9, 2022 13:01 Inactive
Copy link

@AkashKale AkashKale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aniket-k-kaushik Move all the placeholder text to en.yml. Rest LGTM.
Also, can you add a hover in the edit and delete icon. Currently, the clicking experience is too bad.

@vipulnsward vipulnsward temporarily deployed to miru-review-pr-138 February 9, 2022 13:19 Inactive
@vipulnsward vipulnsward temporarily deployed to miru-review-pr-138 February 9, 2022 13:25 Inactive
@aniketkaushik
Copy link
Contributor Author

@aniket-k-kaushik Move all the placeholder text to en.yml. Rest LGTM. Also, can you add a hover in the edit and delete icon. Currently, the clicking experience is too bad.

done @akhilgkrishnan

Copy link
Contributor

@mohinid mohinid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LKTM for issue #136

@vipulnsward vipulnsward temporarily deployed to miru-review-pr-138 February 9, 2022 14:13 Inactive
Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@akhilgkrishnan akhilgkrishnan merged commit 093cbb8 into develop Feb 9, 2022
@akhilgkrishnan akhilgkrishnan deleted the ui-design-mismatch-fix-bug branch February 9, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new user- input boxes for name and email not visible. UI Mismatch : Text Styling - Team page
5 participants