Developed Projects listing page #105

judis007 · 2022-02-01T16:22:08Z

Pull Request Template

Description

Developed the Project listing page which shows the projects and the number of hours logged for that project. It also includes a search bar to search for the projects.

Fixes #82

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I tested locally in my browser whether the required functionality and design is working.

Checklist:

I have manually tested all workflows
I have performed a self-review of my own code
I have added automated tests for my code

keshavbiswa

Some non blocking concerns.

keshavbiswa · 2022-02-02T03:41:36Z

app/controllers/projects_controller.rb

+class ProjectsController < ApplicationController
+  def index
+    if params["query"]
+      @projects = Project.where("name LIKE ?", "%#{params['query']}%")


I think it will be really nice if we could use Ransack gem for the search part.

@keshavbiswa, I have added the Ransack gem. Can you review it once again?

app/controllers/projects_controller.rb

keshavbiswa

Looks good to me 🥂

app/views/projects/index.html.erb

rohitjoshixyz · 2022-02-02T07:13:10Z

app/controllers/projects_controller.rb

+class ProjectsController < ApplicationController
+  def index
+    @q = Project.ransack(params[:q])
+    @projects = @q.result(distinct: true)


Can you check why am I seeing these extra params

@rohitjoshixyz That is from the image_submit_tag. It will include the x and y params. I referred some posts. But I didn't find any solution to get rid of that.

PFA
https://stackoverflow.com/questions/21685559/rails-image-submit-tag-x-y-values

Okay its fine, not a blocker will check it later

* Code quality improvements * locales added * minor code changes * review changes added * review changes added

github-actions · 2022-02-02T10:21:29Z

Current Code Coverage Percent of this PR:

71.84 %

Files having coverage below 100%

Impacted Files	Coverage
/config/application.rb	92.86 %
/config/routes.rb	94.74 %
/app/models/user.rb	83.33 %
/app/controllers/projects_controller.rb	50.0 %
/app/controllers/application_controller.rb	66.67 %
/app/helpers/application_helper.rb	40.0 %
/app/helpers/team_helper.rb	57.14 %
/app/helpers/users/registrations_helper.rb	41.67 %
/app/controllers/company_controller.rb	36.67 %
/app/controllers/root_controller.rb	33.33 %
/app/controllers/team_controller.rb	83.33 %
/app/controllers/users/omniauth_callbacks_controller.rb	25.0 %
/app/controllers/users/sessions_controller.rb	25.0 %
/app/controllers/users/registrations_controller.rb	45.83 %
/app/controllers/users/invitations_controller.rb	63.64 %
/app/controllers/internal_api/v1/application_controller.rb	80.0 %
/app/controllers/internal_api/v1/clients_controller.rb	66.67 %

akhilgkrishnan

@judis007 added some minor comments

app/views/projects/index.html.erb

app/controllers/projects_controller.rb

akhilgkrishnan

LGTM 👍 . Can add some projects to seed.rb

rohitjoshixyz

LGTM

added projects listing page

58e9770

pr-triage bot added the PR: unreviewed label Feb 1, 2022

vipulnsward temporarily deployed to miru-review-pr-105 February 1, 2022 16:22 Inactive

judis007 changed the title ~~Developed Projects listing page~~ [WIP] Developed Projects listing page Feb 1, 2022

pr-triage bot removed the PR: unreviewed label Feb 1, 2022

keshavbiswa reviewed Feb 2, 2022

View reviewed changes

judis007 requested a review from akhilgkrishnan February 2, 2022 05:43

judis007 changed the title ~~[WIP] Developed Projects listing page~~ Developed Projects listing page Feb 2, 2022

pr-triage bot added the PR: unreviewed label Feb 2, 2022

added ransack gem for searching

d13b423

vipulnsward temporarily deployed to miru-review-pr-105 February 2, 2022 06:44 Inactive

judis007 requested a review from keshavbiswa February 2, 2022 06:46

keshavbiswa approved these changes Feb 2, 2022

View reviewed changes

pr-triage bot added PR: partially-approved and removed PR: unreviewed labels Feb 2, 2022

rohitjoshixyz reviewed Feb 2, 2022

View reviewed changes

app/views/projects/index.html.erb Outdated Show resolved Hide resolved

rohitjoshixyz reviewed Feb 2, 2022

View reviewed changes

akhilgkrishnan and others added 3 commits February 2, 2022 15:47

Code improvements (#107)

37f5434

* Code quality improvements * locales added * minor code changes * review changes added * review changes added

removed the pending specs

47bcbe9

added en locale

8423ddd

pr-triage bot added PR: unreviewed and removed PR: partially-approved labels Feb 2, 2022

vipulnsward temporarily deployed to miru-review-pr-105 February 2, 2022 10:18 Inactive

Merge branch 'develop' into project-list

e95d7b8

vipulnsward temporarily deployed to miru-review-pr-105 February 2, 2022 10:19 Inactive

akhilgkrishnan reviewed Feb 2, 2022

View reviewed changes

app/views/projects/index.html.erb Outdated Show resolved Hide resolved

app/controllers/projects_controller.rb Outdated Show resolved Hide resolved

judis007 added 2 commits February 2, 2022 17:48

changed the @q to @query in the index action

168452e

added project request spec

f7ad02b

vipulnsward temporarily deployed to miru-review-pr-105 February 2, 2022 12:18 Inactive

akhilgkrishnan approved these changes Feb 2, 2022

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Feb 2, 2022

judis007 merged commit 022e01a into develop Feb 2, 2022

pr-triage bot added PR: merged and removed PR: reviewed-approved labels Feb 2, 2022

judis007 deleted the project-list branch February 2, 2022 12:45

pr-triage bot added PR: reviewed-approved and removed PR: merged labels Feb 2, 2022

rohitjoshixyz reviewed Feb 2, 2022

View reviewed changes

pr-triage bot added PR: merged and removed PR: reviewed-approved labels Feb 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Developed Projects listing page #105

Developed Projects listing page #105

judis007 commented Feb 1, 2022 •

edited

Loading

keshavbiswa left a comment

keshavbiswa Feb 2, 2022

judis007 Feb 2, 2022

keshavbiswa left a comment

rohitjoshixyz Feb 2, 2022

judis007 Feb 2, 2022

rohitjoshixyz Feb 2, 2022

github-actions bot commented Feb 2, 2022

akhilgkrishnan left a comment

akhilgkrishnan left a comment •

edited

Loading

rohitjoshixyz left a comment

Developed Projects listing page #105

Developed Projects listing page #105

Conversation

judis007 commented Feb 1, 2022 • edited Loading

Pull Request Template

Description

Type of change

How Has This Been Tested?

Checklist:

keshavbiswa left a comment

Choose a reason for hiding this comment

keshavbiswa Feb 2, 2022

Choose a reason for hiding this comment

judis007 Feb 2, 2022

Choose a reason for hiding this comment

keshavbiswa left a comment

Choose a reason for hiding this comment

rohitjoshixyz Feb 2, 2022

Choose a reason for hiding this comment

judis007 Feb 2, 2022

Choose a reason for hiding this comment

rohitjoshixyz Feb 2, 2022

Choose a reason for hiding this comment

github-actions bot commented Feb 2, 2022

Current Code Coverage Percent of this PR:

71.84 %

Files having coverage below 100%

akhilgkrishnan left a comment

Choose a reason for hiding this comment

akhilgkrishnan left a comment • edited Loading

Choose a reason for hiding this comment

rohitjoshixyz left a comment

Choose a reason for hiding this comment

judis007 commented Feb 1, 2022 •

edited

Loading

akhilgkrishnan left a comment •

edited

Loading