Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time entries marked as billed when invoice is in sending phase. #1853

Closed
sonamvg opened this issue May 27, 2024 · 0 comments · Fixed by #1860
Closed

Time entries marked as billed when invoice is in sending phase. #1853

sonamvg opened this issue May 27, 2024 · 0 comments · Fixed by #1860
Assignees
@nisusam
Labels
bug Something isn't working

Comments

@sonamvg
Copy link
Contributor

sonamvg commented May 27, 2024

Description

Time entries are marked as billed when the invoice is stuck in the sending phase.

What is the expected behaviour?

If an invoice is stuck in "sending" state, the entries should not be marked as billed.

  • Entries should be in unbilled state.
  • Once the invoice is sent entry should be marked as billed

What is the current behaviour?

If an invoice is stuck in "sending" state, the entries are marked as billed.

  • Entries should be are marked as billed
  • any changes to invoice, like resending or deleting does not make change to the entries

How to reproduce the issue?

  1. Create an invoice and send it.
  2. By making changes to memory or other parameters, have the invoice stuck in sending phase
  3. Delete the entries by editing the invoice( This should mark the entries as unbilled)
  4. Delete the invoice.
  5. Entries are marked as billed.

Screenshots or Screencast

Please provide any traces or logs that could help here.

Any possible solutions?

If the bug is confirmed, would you be willing to submit a PR?
@sonamvg sonamvg added the bug Something isn't working label May 27, 2024
@sonamvg sonamvg assigned apoorv1316 and nisusam and unassigned apoorv1316 May 27, 2024
nisusam pushed a commit that referenced this issue Jun 10, 2024
Mark timesheet entries as billed only when invoice is sent succes…
4881e87 
…sfully

- Fix #1853
- Couple of weeks back, invoices stuck in `sending` state due to insufficient memory at sidekiq
- And, we found this issue that timesheet entries were `billed`
- These timesheet entries must be marked as `billed` only when invoice
  is in `sent` state
nisusam pushed a commit that referenced this issue Jun 10, 2024
Mark timesheet entries as billed only when invoice is sent succes…
2663f8d 
…sfully

- Fix #1853
- Couple of weeks back, invoices stuck in `sending` state due to insufficient memory at sidekiq
- And, we found this issue that timesheet entries were `billed`
- These timesheet entries must be marked as `billed` only when invoice
  is in `sent` state
@nisusam nisusam mentioned this issue Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nisusam nisusam

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark timesheet entries as billed only when invoice is sent successfully saeloun/miru-web
3 participants
@nisusam @apoorv1316 @sonamvg