Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent infinite loop on empty xml elements #158

Merged
merged 1 commit into from
Jan 9, 2019

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Jan 8, 2019

refs #132 and #146

About dropping code coverage: it is hard to make reader->read() to return false and hit these 5 lines.
The only possibility would be to mock the reader and fake this behavior - which is very unlikly.

I never the less would like to keep these checks since they can cause trouble if the occur.

ToDo

@DeepDiver1975 DeepDiver1975 self-assigned this Jan 8, 2019
@codecov
Copy link

codecov bot commented Jan 8, 2019

Codecov Report

Merging #158 into master will decrease coverage by 1.28%.
The diff coverage is 62.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #158      +/-   ##
============================================
- Coverage     98.87%   97.58%   -1.29%     
  Complexity      112      112              
============================================
  Files            13       13              
  Lines           444      456      +12     
============================================
+ Hits            439      445       +6     
- Misses            5       11       +6
Impacted Files Coverage Δ Complexity Δ
lib/Deserializer/functions.php 89.69% <62.5%> (-5.61%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe7c953...cde4364. Read the comment docs.

@staabm
Copy link
Member

staabm commented Jan 9, 2019

after getting in the changes discussed in #159 we get move ahead.

thx

@rullzer
Copy link

rullzer commented Jan 11, 2019

👍 good stuff @DeepDiver1975

kesselb added a commit to kesselb/sabre-dav that referenced this pull request Oct 10, 2021
Port sabre-io/xml#158 to the prop parser to sabre/dav

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb added a commit to kesselb/sabre-dav that referenced this pull request Nov 2, 2021
Port sabre-io/xml#158 to the prop parser to sabre/dav

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
phil-davis pushed a commit to kesselb/sabre-dav that referenced this pull request Nov 3, 2021
Port sabre-io/xml#158 to the prop parser to sabre/dav

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
phil-davis pushed a commit to kesselb/sabre-dav that referenced this pull request Nov 3, 2021
Port sabre-io/xml#158 to the prop parser to sabre/dav

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
phil-davis pushed a commit to kesselb/sabre-dav that referenced this pull request Nov 3, 2021
Port sabre-io/xml#158 to the prop parser to sabre/dav

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
phil-davis pushed a commit to kesselb/sabre-dav that referenced this pull request Nov 16, 2021
Port sabre-io/xml#158 to the prop parser to sabre/dav

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants