-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent infinite loop on empty xml elements #158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
============================================
- Coverage 98.87% 97.58% -1.29%
Complexity 112 112
============================================
Files 13 13
Lines 444 456 +12
============================================
+ Hits 439 445 +6
- Misses 5 11 +6
Continue to review full report at Codecov.
|
3005913
to
77be44c
Compare
This was referenced Jan 8, 2019
after getting in the changes discussed in #159 we get move ahead. thx |
77be44c
to
cde4364
Compare
This was referenced Jan 9, 2019
👍 good stuff @DeepDiver1975 |
kesselb
added a commit
to kesselb/sabre-dav
that referenced
this pull request
Oct 10, 2021
Port sabre-io/xml#158 to the prop parser to sabre/dav Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
added a commit
to kesselb/sabre-dav
that referenced
this pull request
Nov 2, 2021
Port sabre-io/xml#158 to the prop parser to sabre/dav Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
phil-davis
pushed a commit
to kesselb/sabre-dav
that referenced
this pull request
Nov 3, 2021
Port sabre-io/xml#158 to the prop parser to sabre/dav Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
phil-davis
pushed a commit
to kesselb/sabre-dav
that referenced
this pull request
Nov 3, 2021
Port sabre-io/xml#158 to the prop parser to sabre/dav Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
phil-davis
pushed a commit
to kesselb/sabre-dav
that referenced
this pull request
Nov 3, 2021
Port sabre-io/xml#158 to the prop parser to sabre/dav Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
phil-davis
pushed a commit
to kesselb/sabre-dav
that referenced
this pull request
Nov 16, 2021
Port sabre-io/xml#158 to the prop parser to sabre/dav Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #132 and #146
About dropping code coverage: it is hard to make reader->read() to return false and hit these 5 lines.
The only possibility would be to mock the reader and fake this behavior - which is very unlikly.
I never the less would like to keep these checks since they can cause trouble if the occur.
ToDo