Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed issue: Undefined index: plusminus #467 #619

Merged
merged 2 commits into from
Nov 9, 2023
Merged

fixed issue: Undefined index: plusminus #467 #619

merged 2 commits into from
Nov 9, 2023

Conversation

sash04ek
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jun 20, 2023 •
edited
Loading

Codecov Report

Merging #619 (e4d7c4e) into master (9341286) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #619   +/-   ##
=========================================
  Coverage     98.76%   98.76%           
- Complexity     1865     1866    +1     
=========================================
  Files            71       71           
  Lines          5325     5325           
=========================================
  Hits           5259     5259           
  Misses           66       66
Files Coverage Δ
lib/DateTimeParser.php 98.31% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@staabm
Copy link
Member

staabm commented Jun 21, 2023

could you add a test?

@sash04ek
Copy link
Contributor Author

could you add a test?

i just added the test.

@phil-davis
Copy link
Contributor

i just added the test.

I don't see any test - let me see if it is easy to write one.

@DeepDiver1975
Copy link
Member

le test: #622

@phil-davis
Copy link
Contributor

le test: #622

I added a short test that failed locally without this fix:

There was 1 error:

1) Sabre\VObject\DateTimeParserTest::testParseDuration
Undefined index: plusminus

So I will merge here, then look at adding the other test.

@phil-davis phil-davis merged commit c832cc3 into sabre-io:master Nov 9, 2023
7 checks passed
This was referenced Nov 9, 2023
Merged
Closed
Merged
kesselb added a commit to nextcloud/3rdparty that referenced this pull request Nov 12, 2023
@kesselb
chore: update sabre/vobject and sabre/event to latest minor
9e4d24e 
sabre-io/vobject#619
sabre-io/vobject#623

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb mentioned this pull request Nov 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@staabm staabm staabm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sash04ek @staabm @phil-davis @DeepDiver1975