Ignore multiple same parameter-values #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #577 +/- ##
=========================================
Coverage 98.34% 98.34%
- Complexity 1887 1888 +1
=========================================
Files 71 71
Lines 4532 4533 +1
=========================================
+ Hits 4457 4458 +1
Misses 75 75
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sometimes it seems like parameters can be added multiple times with
the same value. Besides not making any sense (and partially being
not allowed in the first place) this will also possibly break the
further process of parsing an icalendar file.
This modification adds a shortcut when the last parameter-value and the
current parameter value are exactly the same. In that case the new
value is ignored and only the old value will be used.
The use-case - as documented in the test - is that there seem to be
icalendar files that contain the following content:
DTSTART;VALUE=DATE;VALUE=DATE:20220612
While that seems to violate the RFC it is not seen as a violation in
the icalendar validator at https://icalendar.org/validator.html and
as it can also be imported by other calendaring systems it looks like
this should at least not break the parser.
5d2e6cb to
85340b7
Compare
phil-davis
reviewed
Jul 12, 2022
phil-davis
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it seems like parameters can be added multiple times with the same value. Besides not making any sense (and partially being not allowed in the first place) this will also possibly break the further process of parsing an icalendar file.
This modification adds a shortcut when the last parameter-value and the current parameter value are exactly the same. In that case the new value is ignored and only the old value will be used.
The use-case - as documented in the test - is that there seem to be icalendar files that contain the following content:
While that seems to violate the RFC it is not seen as a violation in the icalendar validator at https://icalendar.org/validator.html and as it can also be imported by other calendaring systems it looks like this should at least not break the parser.