Use latest php-cs-fixer 2.17.1 #528
Conversation
c90e244 to
2fd911f
Compare
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
=========================================
Coverage 98.69% 98.69%
Complexity 1757 1757
=========================================
Files 66 66
Lines 4277 4277
=========================================
Hits 4221 4221
Misses 56 56
Continue to review full report at Codecov.
|
|
@DeepDiver1975 @staabm please review. I do not feel comfortable merging it directly - there are quite a few lines of diff. |
| exec(__DIR__.'/sabre-cs-fixer fix '.escapeshellarg($outputFile)); | ||
| exec(__DIR__.'/../vendor/bin/php-cs-fixer fix '.escapeshellarg($outputFile)); |
There was a problem hiding this comment.
hmm not sure its correct that this path changed? could you verify this bin still works?
There was a problem hiding this comment.
I ran fetch_windows_zones.php locally from the root of the repo in order to update the windows zones file.
That is how I found that the old sabre-cs-fixer is no longer, and made it work by doing this.
The latest php-cs-fixer finds some new things. Code changes were needed in sabre-io/dav#1316 for
sabre/dav. We might as well consistently make sure to use at least this version 2.17.1 in all repos so that we are doing consistent code-style checking.It complains about:
_in method names.die()(wants it to beexit())