Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with PHP8.0 #513

Merged
merged 3 commits into from
Oct 3, 2020
Merged

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Oct 3, 2020

  1. sort out variables in .travis.yml for selecting to run php-cs-fixer, phpunit and phpstan
  2. Add a matrix entry to run just phpunit on Ubuntu 20.04 "focal" with "nightly" PHP (which is the way to get PHP 8.0 at the moment)
  3. When not running php-cs-fixer, explicitly remove it from composer.json (because php-cs-fixer does not yet support PHP 8.0, so composer cannot sort out dependencies if we have PHP 8.0 and php-cs-fixer 2.* together)
  4. Fixup calendar parameter to Broker parseEvent

@phil-davis phil-davis self-assigned this Oct 3, 2020
@codecov
Copy link

codecov bot commented Oct 3, 2020

Codecov Report

Merging #513 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #513      +/-   ##
============================================
- Coverage     98.69%   98.67%   -0.02%     
- Complexity     1757     1776      +19     
============================================
  Files            66       66              
  Lines          4279     4304      +25     
============================================
+ Hits           4223     4247      +24     
- Misses           56       57       +1     
Impacted Files Coverage Δ Complexity Δ
lib/ITip/Broker.php 99.50% <100.00%> (ø) 155.00 <21.00> (+1.00)
lib/Property/Boolean.php 50.00% <0.00%> (-3.85%) 6.00% <0.00%> (ø%)
lib/Property/UtcOffset.php 100.00% <0.00%> (ø) 3.00% <0.00%> (ø%)
lib/Property/ICalendar/Period.php 100.00% <0.00%> (ø) 9.00% <0.00%> (ø%)
lib/Property/ICalendar/DateTime.php 100.00% <0.00%> (ø) 44.00% <0.00%> (ø%)
lib/Property/VCard/DateAndOrTime.php 100.00% <0.00%> (ø) 75.00% <0.00%> (ø%)
lib/Parser/MimeDir.php 99.55% <0.00%> (+<0.01%) 85.00% <0.00%> (+3.00%)
lib/Parameter.php 99.20% <0.00%> (+<0.01%) 82.00% <0.00%> (+1.00%)
lib/Property/Text.php 99.13% <0.00%> (+<0.01%) 41.00% <0.00%> (+1.00%)
lib/FreeBusyGenerator.php 98.11% <0.00%> (+<0.01%) 90.00% <0.00%> (ø%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7feca8...ad7ed41. Read the comment docs.

@phil-davis
Copy link
Contributor Author

phil-davis commented Oct 3, 2020

2) Sabre\VObject\Parser\XmlTest::testRFC6321Example1
Function libxml_disable_entity_loader() is deprecated
/home/travis/build/sabre-io/vobject/vendor/sabre/xml/lib/Reader.php:58
/home/travis/build/sabre-io/vobject/lib/Parser/XML.php:358
/home/travis/build/sabre-io/vobject/lib/Parser/XML.php:77
/home/travis/build/sabre-io/vobject/lib/Reader.php:91
/home/travis/build/sabre-io/vobject/tests/VObject/Parser/XmlTest.php:2793
/home/travis/build/sabre-io/vobject/tests/VObject/Parser/XmlTest.php:63

Needs a fix in sabre/xml first - which comes in sabre/xml 2.2

@phil-davis phil-davis marked this pull request as ready for review October 3, 2020 08:58
@phil-davis phil-davis requested a review from staabm October 3, 2020 09:00
@phil-davis
Copy link
Contributor Author

I restarted CI and now https://travis-ci.org/github/sabre-io/vobject/jobs/732473826
- Installing sabre/xml (2.2.2): Downloading (100%)

It finds the new sabre/xml 2.2.2 and the unit tests pass on PHP 8.0

@phil-davis phil-davis merged commit fcc921d into sabre-io:master Oct 3, 2020
@phil-davis phil-davis deleted the test-with-php-8.0 branch October 3, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants