Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): phpstan major version 2 #124

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

phil-davis
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (685ad63) to head (3e615df).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
+ Coverage   97.70%   97.72%   +0.02%     
==========================================
  Files           1        1              
  Lines         174      176       +2     
==========================================
+ Hits          170      172       +2     
  Misses          4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +146 to +147
'http' => 80,
'https' => 443,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note:
parse_url always returns $parts['port'] as an int (if it exists).
So we should do strict comparison below at line 150, and compare integers.
phpstan v2 wants strict === comparisons:

 ------ --------------------------------------------- 
  Line   lib/functions.php                            
 ------ --------------------------------------------- 
  150    Loose comparison via "==" is not allowed.    
         🪪  equal.notAllowed                          
         💡 Use strict comparison via "===" instead.   
 ------ --------------------------------------------- 

@phil-davis phil-davis merged commit 2eee503 into sabre-io:master Dec 2, 2024
8 checks passed
@phil-davis phil-davis deleted the phpstan-2 branch December 2, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants