Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pgsql.calendars.sql #1317

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Update pgsql.calendars.sql #1317

merged 1 commit into from
Nov 16, 2021

Conversation

perguth
Copy link
Contributor

@perguth perguth commented Dec 28, 2020

Add missing primary key declaration.

@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #1317 (7fc2720) into master (71bbf40) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1317   +/-   ##
=========================================
  Coverage     97.35%   97.35%           
  Complexity     2809     2809           
=========================================
  Files           174      174           
  Lines          7976     7976           
=========================================
  Hits           7765     7765           
  Misses          211      211           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71bbf40...7fc2720. Read the comment docs.

@staabm
Copy link
Member

staabm commented Dec 28, 2020

ohh wow. @phil-davis @DeepDiver1975 is this something you could verify?

Add missing primary key declaration.
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mysql.calendars.sql and sqlite.calendars.sql both have id defined as primary key for table schedulingobjects

The change here is the correct way to do this in pgsql, and was missing from this example code.

@phil-davis phil-davis merged commit ba97a9f into sabre-io:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants