Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 409 when trying to PUT a file into a non-existent collection #1306

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

phil-davis
Copy link
Contributor

Fixes #1304

@phil-davis phil-davis self-assigned this Nov 9, 2020
@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #1306 (f02549c) into master (8c15d19) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1306   +/-   ##
=========================================
  Coverage     97.14%   97.14%           
- Complexity     2792     2793    +1     
=========================================
  Files           174      174           
  Lines          8117     8119    +2     
=========================================
+ Hits           7885     7887    +2     
  Misses          232      232           
Impacted Files Coverage Δ Complexity Δ
lib/DAV/Server.php 96.15% <100.00%> (+0.01%) 193.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c15d19...f02549c. Read the comment docs.

@phil-davis
Copy link
Contributor Author

Travis CI has passed: https://travis-ci.org/github/sabre-io/dav/builds/742368329
There is currently trouble or delays with Travis reporting status back to GitHub.

Copy link
Member

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@phil-davis phil-davis merged commit 7c8af5e into sabre-io:master Nov 9, 2020
@phil-davis phil-davis deleted the fix-1304 branch November 9, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PUT request with missing parent must return status code 409
2 participants