test: amount withdrawn after multiple withdrawals #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreivladbrg
requested changes
Sep 21, 2024
test/integration/concrete/multiple-withdrawals/multipleWithdrawals.t.sol
Outdated
Show resolved
Hide resolved
test/integration/concrete/multiple-withdrawals/multipleWithdrawals.t.sol
Outdated
Show resolved
Hide resolved
47cc4cb to
2a3a044
Compare
2a3a044 to
c971673
Compare
|
Pushed the changes @andreivladbrg. lmk if it looks good now. |
test: polish delay test
andreivladbrg
approved these changes
Sep 22, 2024
There was a problem hiding this comment.
LGTM 👍
I have renamed the test to "WithdrawNoDelay" as "MultipleWithdrawals" was not that precise ed9cae0
|
Thanks for approving @andreivladbrg. The name |
smol-ninja
added a commit
that referenced
this pull request
Sep 22, 2024
* test: amount withdrawn after multiple withdrawals * test: rename mvt to scaleFactor * test: rename test to "withdraw no delay" test: polish delay test --------- Co-authored-by: andreivladbrg <andreivladbrg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #251
Includes a test that compares the sum of withdrawn amount through multiple withdrawals with the expected withdrawn amount if there were no precision loss in division.
Note: this test fails against
mainbranch.