-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added encodedSync to get profiles using a Sync method #10
Conversation
fp.setPreference('extensions.firebug.defaultPanelName', 'console'); | ||
fp.updatePreferences(); | ||
fp.addExtensions(testProfile.extensions, function() { | ||
var zippedProfile = fp.encodedSync(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an "SyntaxError: Unexpected end of input", because of an indentation problem here. See other comments at the end of this file.
Aaargh .... copy-paste error. I was editing from the npm module and pasted it here, sorry. |
// because table method is probably added to the regular console | ||
.eval('console.table').then(function(res) { | ||
res.should.contain('function'); | ||
sendStatusToSauceLabs(browser.sessionID, true, function() { done(); }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done() is called here but not defined in the 'it()' callback
Fixed and sent in a new pull request. |
Thanks for your pull request. The build failed for a couple of reasons:
The last point is a show stopper: see cthackers/adm-zip#57. the error I get:
And the selenium server outputs the following:
But if you find another module that can generate valid zips in a synchronous way I will be happy to accept another pull request (I will do some research on my side, but I didn't find anything a couple of weeks ago). To make sure that it works, I think the easiest way is to:
I am sorry but i can't accept that pull request as-is. As a side note: When using karma-sauce-launcher, I think you can do the following:
|
I tried the following, after reading a comment in cthackers/adm-zip#65:
The browser starts but the profile is not correctly loaded (no extensions or userPrefs)... |
Makes sense - will close this and send in a new request later. For the karma tests, the config.set needs to happen immediately, else karma for some reason does not see the config and does not run. |
Oh, I see, config.set() cannot be called asynchronously (in a callback). If you are using grunt-karma, then something similar to this might help (assuming that customLauchners option is supported by grunt-karma in Gruntfile.js): http://stackoverflow.com/questions/16547528/how-can-i-perform-an-asynchronous-operation-before-grunt-initconfig |
I am using this in karma-sauce-launcher and it is much easier to get the profile if it is available synchronously.