Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option to use Release Types (major, minor, patch) for Updates #26

Merged
merged 7 commits into from
Oct 22, 2022

Conversation

saadmk11
Copy link
Owner

closes #22

@saadmk11 saadmk11 added the enhancement New feature or request label Oct 21, 2022
@saadmk11 saadmk11 self-assigned this Oct 21, 2022
@SebastianStehle
Copy link

Awesome, thank you :)

@saadmk11
Copy link
Owner Author

saadmk11 commented Oct 21, 2022

Awesome, thank you :)

Hi @SebastianStehle, Please try it out (saadmk11/github-actions-version-updater@release-type) and let me know if this is working for you or not :)

@SebastianStehle
Copy link

Yes and no. I think the PR should only propose short versions for "major" ... like "@v2" and so on.

See: https://github.com/notifo-io/notifo/pull/135/files

@SebastianStehle
Copy link

SebastianStehle commented Oct 21, 2022

Could also be another setting, e.g. "update_version_with: release-tag-major"

Btw: Can you not prebuilt the docker image? (I have no idea how docker actions work)

@saadmk11
Copy link
Owner Author

Yes and no. I think the PR should only propose short versions for "major" ... like "@v2" and so on.

See: https://github.com/notifo-io/notifo/pull/135/files

Not all actions follow this pattern, and I think using specific tags than a moving tag is better because we know this will always run the same code.

@saadmk11
Copy link
Owner Author

Btw: Can you not prebuilt the docker image? (I have no idea how docker actions work)

Yes, you can.

@SebastianStehle
Copy link

Therefore you have semantic versioning ;)

I would just prefer to get the small improvements and non breaking changes automatically.

@saadmk11 saadmk11 marked this pull request as ready for review October 22, 2022 12:21
@saadmk11
Copy link
Owner Author

saadmk11 commented Oct 22, 2022

Therefore you have semantic versioning ;)

I would just prefer to get the small improvements and non breaking changes automatically.

GitHub is not actually using Semantic Versioning to find the version of an action, it is using Git Tags in case of @v2. So, v2 is not equal to v2.0.0 (like some package managers). The author of the action decides to create a moving tag (e.g.: v2) which is moved after every release of v2.x.x. But it is entirely up to the author and not every action follows this rule.

If the action publishes major version tags, you should expect to receive critical fixes and security patches while still retaining compatibility. Note that this behavior is at the discretion of the action's author.

ref: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsuses

@saadmk11 saadmk11 merged commit b49419d into main Oct 22, 2022
@saadmk11 saadmk11 deleted the release-type branch October 22, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Only suggest major version upgrades
2 participants