Add Accessibility improvements for screen readers #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix two issues related with Accessibility:
To fix the issue 1, now when pressing Tab or ShiftTab, the dropdown closes and the focus is set on .vscomp-ele element.
To fix issue 2, a live-region area was added, that is updated on hovering a new option on the dropdown, triggering the Screen Readers to read the option textContent.
This works perfectly with Windows Narrator and Apple's VoiceOver. On NVDA tool, it always says 'blank' first but then reads the option correctly. Was not able to fix this and it seems a common issue with this tool, as I found multiple reports on other components about this.
A fix was also added to remove some code introduced on #253, that caused the Dropdown not to be reachable by keyboard navigation.
Cypress tests were triggered and all passed: