protoc: use transducer instead of nested map

s-expresso · Dec 23, 2023 · f7f29da · f7f29da
1 parent eda5e65
commit f7f29da
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/src/clojobuf/core.cljc b/src/clojobuf/core.cljc
@@ -62,10 +62,9 @@
           "Generate codec and malli registries and return them as a tuple."
           [paths files & {:keys [auto-malli-registry] :or {auto-malli-registry true}}]
           (let [rast (unnest (rc/protoc paths files))
-        ; TODO below is super inefficient, use transducer or other ways
-                codec_malli_pairs (reduce into [] (map xform-ast (map val rast)))
-                codec (into {} (map first) codec_malli_pairs)
-                malli (into {} (map second) codec_malli_pairs)
+                codec_malli_pairs (transduce (map (comp xform-ast val)) into [] rast)
+                codec             (transduce (map first)                into {} codec_malli_pairs)
+                malli             (transduce (map second)               into {} codec_malli_pairs)
                 malli (if auto-malli-registry
                         (->malli-registry malli)
                         malli)]

diff --git a/src/clojobuf/nodejs.cljs b/src/clojobuf/nodejs.cljs
@@ -10,10 +10,9 @@
   "Generate codec and malli registries and return them as a tuple."
   [paths files & {:keys [auto-malli-registry] :or {auto-malli-registry true}}]
   (let [rast (unnest (rc/protoc paths files))
-        ; TODO below is super inefficient, use transducer or other ways
-        codec_malli_pairs (reduce into [] (map xform-ast (map val rast)))
-        codec (into {} (map first) codec_malli_pairs)
-        malli (into {} (map second) codec_malli_pairs)
+        codec_malli_pairs (transduce (map (comp xform-ast val)) into [] rast)
+        codec             (transduce (map first)                into {} codec_malli_pairs)
+        malli             (transduce (map second)               into {} codec_malli_pairs)
         malli (if auto-malli-registry
                 (->malli-registry malli)
                 malli)]