Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt: added annotation to ignore @preview compose functions, tried to fix jacoco for :core-ui module #86

Merged

Conversation

rygelouv
Copy link
Owner

@rygelouv rygelouv commented Dec 19, 2023


🚀 Description

  • Exclusion of Certain Files from Jacoco Report
    A number of files have been specially marked to be left out by the Jacoco Reporting tool. This means that these files will not be incorporated in the code coverage report generated by Jacoco. The files bear the ExcludeFromJacocoGeneratedReport annotation.

  • Addition of New Files under code-checks
    Several new files have been added under the code-checks module. This module is responsible for conducting automated checks on the code to maintain its quality and ensure that it adheres to the established coding and design norms.

  • Removal of Unused Imports
    Various import statements that were no longer necessary have been removed from different files in the app. This helps to keep the code clean and efficient.

  • Removal of Preview Functions
    Preview functions for various screens and actions have been discontinued. These "preview" functions were previously used to provide a visual mockup of specific pages or features for development and testing purposes.

  • Added Exclude Annotation to Preview Functions
    Some preview functions in the Images.kt, Tags.kt, and Texts.kt files have been marked with the ExcludeFromJacocoGeneratedReport annotation. Thus, these functions won't be included in the Jacoco test coverage report.

  • New Dependency Added
    A new dependency for lint-api version 31.2.0 has been added. The lint-api is a set of tools used by Android developers to scan code for errors, bugs, and conformity to prescribed coding guidelines.

  • New Module Added
    A new module, code-checks, has been added to the project settings. This module handles the automated checking of the project's codes. This helps ensure that coding standards are maintained and increases the overall quality and reliability of the code.

Issue (if applicable):

🖼 Screenshots/Videos (if applicable)

  • Before:
    [Attach before screenshot or link to video]

  • After:
    [Attach after screenshot or link to video]

📦 Dependencies

  • Added new dependencies? List:
  • Updated existing?

🧪 Testing

Describe the steps to reproduce:

📱 Checklist

  • Tested on all supported devices and OS versions
  • UI/UX conforms to project design guidelines
  • Unit/integration tests added
  • Relevant documentation updated (e.g., README, Wiki, etc.)
  • Checked linter on local.

@rygelouv rygelouv added Infrastructure When doing a project infrastructure related work coverage Anything related to code coverage labels Dec 19, 2023
@rygelouv rygelouv added this to the 0.5.0 milestone Dec 19, 2023
@rygelouv rygelouv self-assigned this Dec 19, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR automatically approved by auto-approve-action

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (39f80ee) 30.59% compared to head (dfb57e4) 30.56%.

Files Patch % Lines
...books/tanga/feature/onboarding/OnboardingScreen.kt 0.00% 6 Missing ⚠️
...p/books/tanga/feature/pricing/PricingPlanScreen.kt 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev      #86      +/-   ##
============================================
- Coverage     30.59%   30.56%   -0.04%     
  Complexity       45       45              
============================================
  Files           123      123              
  Lines          4376     4384       +8     
  Branches        738      743       +5     
============================================
+ Hits           1339     1340       +1     
- Misses         2756     2763       +7     
  Partials        281      281              
Flag Coverage Δ
uitests 18.66% <0.00%> (+0.07%) ⬆️
unittests 14.87% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rygelouv rygelouv merged commit 2052240 into dev Dec 19, 2023
3 of 5 checks passed
rygelouv added a commit that referenced this pull request Dec 19, 2023
…to fix jacoco for :core-ui module but failed (#86)"

This reverts commit 2052240.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coverage Anything related to code coverage Infrastructure When doing a project infrastructure related work
Projects
Development

Successfully merging this pull request may close these issues.

1 participant