Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed and improved Mini player visibility behaviour and added ui improvements #123

Merged
merged 3 commits into from
Dec 31, 2024

Conversation

rygelouv
Copy link
Owner

@rygelouv rygelouv commented Dec 31, 2024


🚀 Description

We have implemented the changes requested here #122
And have made some additional UI improvements.
We have also removed the "Purchase book" feature. This feature didin't bring much value to the product. At least for now.

Issue (if applicable):

🖼 Screenshots/Videos (if applicable)

Screen.Recording.2024-12-31.at.11.59.36.AM.mov
Screen.Recording.2024-12-31.at.12.01.06.PM.mov

📦 Dependencies

  • Added new dependencies? List:
  • Updated existing?

🧪 Testing

📱 Checklist

  • Tested on all supported devices and OS versions
  • UI/UX conforms to project design guidelines
  • Unit/integration tests added
  • Relevant documentation updated (e.g., README, Wiki, etc.)
  • Checked linter on local.

- Added `MiniPlayerAwareSpacer` to `SummariesByCategoryScreen`, `ReadSummaryScreen`, `SettingsScreen`, `ProfileScreen`, `SearchScreen`, and `LibraryScreen` to avoid overlapping content with the mini player.
- Removed extra space added for mini player on `SummariesByCategoryScreen` and `SearchScreen`.
@rygelouv rygelouv added new feature When adding a new feature refactor when doing some refactoring task labels Dec 31, 2024
@rygelouv rygelouv added this to the 1.3.0 milestone Dec 31, 2024
@rygelouv rygelouv self-assigned this Dec 31, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR automatically approved by auto-approve-action

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 43.90244% with 23 lines in your changes missing coverage. Please review.

Project coverage is 31.92%. Comparing base (f32bd2b) to head (119c929).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ure/audioplayer/miniplayer/MiniPlayerVisibility.kt 20.83% 18 Missing and 1 partial ⚠️
...ture/audioplayer/miniplayer/MiniPlayerViewModel.kt 50.00% 0 Missing and 2 partials ⚠️
...tanga/feature/audioplayer/miniplayer/MiniPlayer.kt 0.00% 1 Missing ⚠️
...java/app/books/tanga/feature/main/MainViewModel.kt 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #123      +/-   ##
==========================================
+ Coverage   31.89%   31.92%   +0.03%     
==========================================
  Files         140      141       +1     
  Lines        3744     3778      +34     
  Branches      718      731      +13     
==========================================
+ Hits         1194     1206      +12     
- Misses       2287     2307      +20     
- Partials      263      265       +2     
Flag Coverage Δ
unittests 31.92% <43.90%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rygelouv rygelouv merged commit 70b269d into dev Dec 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature When adding a new feature refactor when doing some refactoring task
Projects
Development

Successfully merging this pull request may close these issues.

1 participant