Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Push notifications #120

Merged
merged 5 commits into from
Dec 29, 2024

Conversation

rygelouv
Copy link
Owner


🚀 Description

We have added support for push notifications.

  • Notification service
  • Notificaiton handling
  • Notification Permission logic
  • Notificaiton permission screen
  • Triggering notification permission request from Auth and summary details screen

Issue (if applicable):

🖼 Screenshots/Videos (if applicable)

Screen.Recording.2024-12-27.at.5.22.00.PM.mov

📦 Dependencies

  • Added new dependencies? List:
  • Updated existing?

🧪 Testing

Describe the steps to reproduce:

📱 Checklist

  • Tested on all supported devices and OS versions
  • UI/UX conforms to project design guidelines
  • Unit/integration tests added
  • Relevant documentation updated (e.g., README, Wiki, etc.)
  • Checked linter on local.

@rygelouv rygelouv added the new feature When adding a new feature label Dec 29, 2024
@rygelouv rygelouv added this to the 1.3.0 milestone Dec 29, 2024
@rygelouv rygelouv self-assigned this Dec 29, 2024
github-actions[bot]
github-actions bot previously approved these changes Dec 29, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR automatically approved by auto-approve-action

@rygelouv rygelouv changed the title Rygelouv/feature/implement push notifications Added support for Push notifications Dec 29, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR automatically approved by auto-approve-action

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 43.35260% with 98 lines in your changes missing coverage. Please review.

Project coverage is 31.89%. Comparing base (bbc43db) to head (6fd24e8).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ks/tanga/notifications/TangaNotificationBuilder.kt 0.00% 32 Missing ⚠️
.../notifications/TangaFirebaseNotificationService.kt 0.00% 22 Missing ⚠️
...in/java/app/books/tanga/utils/ResourcesProvider.kt 0.00% 9 Missing ⚠️
.../app/books/tanga/navigation/MainNavigationGraph.kt 0.00% 6 Missing ⚠️
...in/java/app/books/tanga/navigation/RootNavGraph.kt 0.00% 6 Missing ⚠️
...data/preferences/DefaultPrefDataStoreRepository.kt 0.00% 5 Missing ⚠️
...pp/books/tanga/feature/auth/AuthSignInBehaviour.kt 0.00% 3 Missing ⚠️
...feature/summary/details/SummaryDetailsViewModel.kt 71.42% 0 Missing and 2 partials ⚠️
...books/tanga/notifications/NotificationConstants.kt 0.00% 2 Missing ⚠️
...nga/notifications/NotificationPermissionHandler.kt 87.50% 0 Missing and 2 partials ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #120      +/-   ##
==========================================
+ Coverage   31.34%   31.89%   +0.54%     
==========================================
  Files         131      140       +9     
  Lines        3576     3744     +168     
  Branches      692      718      +26     
==========================================
+ Hits         1121     1194      +73     
- Misses       2201     2287      +86     
- Partials      254      263       +9     
Flag Coverage Δ
unittests 31.89% <43.35%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rygelouv rygelouv merged commit 1332abc into dev Dec 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature When adding a new feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant