Update JetBrainsMono to version v2.210 #540
Conversation
* Remove old patched and unpatched font files * Remove old license file * Separate ligature and non-ligature font versions * Update READMEs * Add new font version
cc218e4 to
bb5ce4f
Compare
|
Alright, this PR is now ready for review. I haven't done any visual comparisons and checks yet like I did in #518 but will do it tomorrow. |
|
There is a regression in Windows Terminal -- double-width icons are squished into single-width. Interestingly, this does not concern VSCode's or JetBrains IDE's terminal, just Windows Terminal. (So this might be a Windows Terminal issue -- but still, the issue is not occurring for the version currently in master.) Version in master: This PR: The prompt text is: |
|
It’s not just that terminal. I’ve seen it in my Alacritty as well. Not sure how to go about it though.
…Sent from my iPhone
On 24. Nov 2020, at 22:18, Jan Pokorný ***@***.***> wrote:
There is a regression in Windows Terminal -- double-width icons are squished into single-width. Interestingly, this does not concern VSCode's or JetBrains IDE's terminal, just Windows Terminal. (So this might be a Windows Terminal issue -- but still, the issue is not occurring for the version currently in master.)
Version in master:
This PR:
The prompt text is:
Main on master [?⇣]
❯
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
@moritzdietz Are you okay with me closing #518 now that you have a new PR for the latest version? I only ask in case you want credit for work done in both 😄. I am happy to go either way here, just let me know! |
|
@ryanoasis Sure you can close the other PR. I don't think folks are particularly interested in that specific version of the font anyway so I don't think it needs to be in the repo. So meh 🤷♂️ One thing I want to mention is that I did notice some behaviour change for glyphs too. I "had" to replace the ❯ character with a bolder one as it was too tiny in my prompt. Can we do anything about this? |
|
Relating to #487 (comment) … @moritzdietz @ryanoasis Are the versions with the
|
|
@JanPokorny I used the directory structure provided by the zip download of the original font and it should be the same. So if you go to either of the two folders here https://github.com/moritzdietz/nerd-fonts/tree/moritzdietz/JetBrainsMono-2.210/patched-fonts/JetBrainsMono you should get the right version. |
|
@moritzdietz Yep, can confirm it works, nice one! (…Although there are effectively duplicate fonts, since the |
|
Well before we can merge this I'd first like to talk about the change in glyph size - as mentioned before. |
|
FYI there's a new release of JBMono: https://github.com/JetBrains/JetBrainsMono/releases/tag/v2.221 |
|
@kidonng There is an issue with the version you linked - JetBrains/JetBrainsMono#387 Yet I'd love to get some feedback on whether we/I can do something about the issues described here. |
|
@moritzdietz Looks like the issue is fixed in JetBrains/JetBrainsMono@e41fd05, so just wait for an official release. Still, thanks for the updated fonts! ❤️ |
|
Ok, I just made a new PR #572. This could, like the other one be merged or not, I don't really have an opinion about it :) |
|
Can this be merged? There's an issue with the current Nerd Font version with spacing between box characters that there's a fix for in the newer JetBrainsMono version. |
Description
This PR updates JetBrainsMono to version v2.210. This is a follow up PR for #518.
Requirements / Checklist
fontforge -script font-patcher src/unpatched-fonts/JetBrainsMono/Ligatures/Regular/JetBrainsMono-Regular.ttf --complete./gotta-patch-em-all-font-patcher\!.sh JetBrainsMonoScript output:
fontforge -script font-patcher src/unpatched-fonts/JetBrainsMono/Ligatures/Regular/JetBrainsMono-Regular.ttf --complete
./gotta-patch-em-all-font-patcher\!.sh JetBrainsMono