Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Italian translation for README #427

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Add Italian translation for README #427

merged 1 commit into from
Jan 30, 2020

Conversation

JGiola
Copy link
Contributor

@JGiola JGiola commented Jan 27, 2020

Description

This adds the Italian version of the README file for advancing the #118 issue.
I have added the Caskaydia Cove Nerd Fontline in the available font table even if in master the links are broken. Is better to keep that out?

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

@ryanoasis
Copy link
Owner

Thanks!

I have added the Caskaydia Cove Nerd Fontline in the available font table even if in master the links are broken. Is better to keep that out

Good catch, I have since fixed in in the main readme, feel free to carry over the same change or if not I can fix after your change is merged

@JGiola
Copy link
Contributor Author

JGiola commented Jan 29, 2020

I’ve updated the file with the latest fix in master 👍

@ryanoasis
Copy link
Owner

Great, thanks!

I spot checked (because that's all I can do) and it looks good!

@ryanoasis ryanoasis added this to the v2.1.0 milestone Jan 30, 2020
@ryanoasis ryanoasis merged commit c881b5c into ryanoasis:master Jan 30, 2020
@JGiola JGiola deleted the feature/italian-readme branch January 30, 2020 11:21
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants