Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix src in elixir screenshot img tag #419

Merged
merged 1 commit into from
Jan 19, 2020
Merged

fix src in elixir screenshot img tag #419

merged 1 commit into from
Jan 19, 2020

Conversation

kadimisetty
Copy link
Contributor

@kadimisetty kadimisetty commented Jan 15, 2020

Description

fixes img src url for elixir screenshot in readme

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

fixes img src url for elixir screenshot in readme

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

@ryanoasis
Copy link
Owner

Thanks for the fix and contribution!

I think this might be an issue upstream, we are simply copying the same readme with some amended info specific for the Nerd Font patch.

@ryanoasis ryanoasis merged commit b0dbf40 into ryanoasis:master Jan 19, 2020
@ryanoasis ryanoasis added this to the v2.1.0 milestone Jan 19, 2020
@kadimisetty kadimisetty deleted the patch-1 branch January 20, 2020 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants