Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve formatting of Agave Readme #379

Merged
merged 1 commit into from
Oct 12, 2019
Merged

Improve formatting of Agave Readme #379

merged 1 commit into from
Oct 12, 2019

Conversation

Roshanjossey
Copy link
Contributor

Description

Update the formatting to use Markdown format to display correctly on GitHub

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
        I figured this step wasn't necessary for this change
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

Improves the formatting of documentation with appropriate format

How should this be manually tested?

Check the Readme file on GitHub

@ryanoasis
Copy link
Owner

Thanks, good improvement!

There is a potential issue in that these changes will be eventually be overwritten due to how the patched fonts readmes are generated.

See my comment here for more details: #381 (comment)

@ryanoasis ryanoasis merged commit 74d0ddc into ryanoasis:master Oct 12, 2019
@ryanoasis ryanoasis added this to the v2.1.0 milestone Oct 12, 2019
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
Improve formatting of Agave Readme (intermediate fix)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants