Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the negative error number #361

Merged
merged 1 commit into from
Jul 27, 2019
Merged

Fix the negative error number #361

merged 1 commit into from
Jul 27, 2019

Conversation

nogweii
Copy link
Collaborator

@nogweii nogweii commented Jul 25, 2019

Description

This fixes the shellcheck error. Running on my laptop, exit -1 results in an actual return code of 255, so make that explicit.

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

This should help with the Travis CI failures.

This fixes the shellcheck error. Running on my laptop, `exit -1` results in an actual return code of 255, so make that explicit.
@ryanoasis
Copy link
Owner

Thanks good catch. Interesting, so it looks like it is actually 255 because it is 'out of range' of the error codes: http://tldp.org/LDP/abs/html/exitcodes.html

Perhaps we should just make it 1 ?

I can merge this tomorrow

@ryanoasis ryanoasis merged commit cac7428 into master Jul 27, 2019
@ryanoasis ryanoasis added this to the v2.1.0 milestone Feb 2, 2020
@ryanoasis
Copy link
Owner

marking on 2.1.0 release, need to update changelog and all-contributors

LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
@Finii Finii deleted the evaryont-patch-1 branch March 16, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants