Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Iosevka to 2.1.0 #328

Merged
merged 3 commits into from
Apr 7, 2019
Merged

Update Iosevka to 2.1.0 #328

merged 3 commits into from
Apr 7, 2019

Conversation

MindTooth
Copy link
Contributor

Description

Update Iosevka to 2.1.0. Please look over if I've done it right. Were a bit scared as the documentation don't specify a approach for just updating a font.

I've copied over the files from the new release, however I'm missing some new styles. But were a bit unsure wether to include them. Please hack at my branch if need be. I've at least done the task of copying each original font into the src folders.

OT: Noticed that the gotta-patch-em-all did not complain about missing the configparser for Python. And I did not notice at firs that the fonts did not get created. Maybe add a check there as well?

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

@MindTooth MindTooth changed the title Update iosevka to 2.1.0 Update Iosevka to 2.1.0 Feb 19, 2019
@ryanoasis
Copy link
Owner

Thanks for the contribution @MindTooth 😄 . I will look it over.

Were a bit scared as the documentation don't specify a approach for just updating a font.

Would you mind elaborating? I want to make continuously make the docs better/easier.

If you executed ./gotta-patch-em-all-font-patcher\!.sh XYZ where XYZ is the name of the font it would have re-patched just that particular font set.

It seems like you followed https://github.com/ryanoasis/nerd-fonts/blob/master/contributing.md#steps-for-adding-a-new-font-or-removing-an-existing-font ? If so that should be good enough in most cases

@MindTooth
Copy link
Contributor Author

Thanks. 😄

Well, when it read only add/remove I felt unsure about right the steps required. An own guide on how to update would help not just for me, but perhaps others as well.

Is a script suitable to do the downloading and patching? Like with this font; it's just a version bump.

@ryanoasis
Copy link
Owner

I agree with you on a separate guide for UPDATING as well as script to execute the steps. Thanks

@ryanoasis ryanoasis added this to the v2.1.0 milestone Apr 7, 2019
@ryanoasis ryanoasis merged commit bdea206 into ryanoasis:master Apr 7, 2019
@MindTooth MindTooth deleted the update_iosevka branch April 7, 2019 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants