Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor font patcher #288

Merged
merged 6 commits into from
Jul 6, 2019
Merged

Conversation

haasosaurus
Copy link
Contributor

@haasosaurus haasosaurus commented Aug 4, 2018

Description

put most code in functions
broke some functions into multiple functions
put most functions in a class
put 2 blank lines between all functions
renamed some variables/parameters for to make their purposes more clear
renamed some functions to make their purposes more clear
aligned some groups of lists, dicts, etc elements for better readability
changed some lists and dicts to put their elements on separate lines
changed conditions var == False to var is False
removed extra commas in lists and dicts
removed whitespace in brackets, braces, etc that touches the brackets, braces, etc
added whitespace after commas in lists and dicts
added whitespace around operators
changed FIXME and TODO to uppercase
added 4 NOTEs in regards to questions i had
changed unneeded returned variables to underscores
changed some update_progress block comments to a docstring
added some docstrings

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

refactors font-patcher

How should this be manually tested?

patch any or all fonts with any options

Any background context you can provide?

What are the relevant tickets (if any)?

none

Screenshots (if appropriate or helpful)

@haasosaurus haasosaurus closed this Aug 7, 2018
@haasosaurus haasosaurus reopened this Aug 7, 2018
@ryanoasis ryanoasis added this to the v2.2.0 milestone Sep 25, 2018
@ryanoasis
Copy link
Owner

Just want to let you know again this is very appreciated and I am sorry I haven't been able to get to reviewing it yet, also this is probably going to get into the 2.2.0 release not the 2.1.0, thanks for understanding!

@ryanoasis ryanoasis closed this Oct 21, 2018
@ryanoasis ryanoasis reopened this Oct 21, 2018
@ryanoasis
Copy link
Owner

Whoops I didn't mean to close and comment, just comment 😅

@ryanoasis ryanoasis merged commit c5433d8 into ryanoasis:master Jul 6, 2019
@ryanoasis ryanoasis modified the milestones: v2.2.0, v2.1.0 Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants