Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switched google fonts link to https #276

Merged
merged 1 commit into from
Aug 2, 2018
Merged

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Jun 8, 2018

Description

switched google fonts link to https, to get rid of blocking Mixed Content error (at least for Chrome 67)

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

changes goole fonts url from http to https

How should this be manually tested?

Load the github page and check if font loads correctly

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

fixes a blocking Mixed Content error.
@ryanoasis ryanoasis added this to the v2.1.0 milestone Jul 19, 2018
@ryanoasis
Copy link
Owner

Thanks for this. Looks good to me.

@ryanoasis ryanoasis merged commit 08336c6 into ryanoasis:gh-pages Aug 2, 2018
@mashehu mashehu deleted the patch-1 branch August 2, 2018 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants