-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overpass Nerdfont kerning is incorrect #703
Comments
Hmmm. I have no issues with the unpatched Overpass Mono from Google Fonts. Also, I have issues with the patched version in EVERY application, not just Gnome terminal. |
Hmm, dowloaded Overpass-Mono from G-Fonts and patched with HEAD. Shows ok in Tilix. I can not, however, select it with Gnome Terminal. But it (Terminal) looks different to yours: But then, no wonder: $ ttfdump Overpass\ Mono\ Regular\ Nerd\ Font\ Complete\ Mono.ttf | grep 'advanceWidthMa|maxCompositePoin|xAvgCharWi'
advanceWidthMax: 1517
maxCompositePoints: 94
xAvgCharWidth: 1232 |
Well ... if I use a This does not mean the patch of #695, but this unpushed stuff:
If you want to try, just set all |
This is fixed in
All widths consistent. |
I'm having this issue on Overpass-Mono-NF 2.3.1 installed through scoop on Win11: Windows Font says 2.3.0, somehow. The issue happens with the file downloaded from directly from GitHub too: |
Sorry to hear that you have problems, will have a look right away. The v2.3.1 is actually marked in the font files as v2.3.0 because only very few font files got any change with the bugfix version, and it was clear to me we will need a 2.3.2 anyhow ;) |
Confirmed. Adding more information here along the way (to prevent spamming ppl with emails) Hmm, there IS a warning
Found the problem... was a typo in the code :-( Thanks for reporting, PR on the way. |
[why] With commit 99c2608 font-patcher: Fix more 'Nerd Font Mono' too wide the glyphs 'ij' and 'IJ' are exempted from the advance width calculation, because some fonts (i.e. Overpass Mono) defines them as two cell wide glyphs (Hello? 'Mono'?) For some obscure reason it was 'IJ' and 'J circumflex' that were exempt, not 'ij'. [how] Exempt correct code. Fixes: #703 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] With commit 99c2608 font-patcher: Fix more 'Nerd Font Mono' too wide the glyphs 'ij' and 'IJ' are exempted from the advance width calculation, because some fonts (i.e. Overpass Mono) defines them as two cell wide glyphs (Hello? 'Mono'?) For some obscure reason it was 'IJ' and 'J circumflex' that were exempt, not 'ij'. [how] Exempt correct code. Fixes: #703 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
[why] With commit 99c2608 font-patcher: Fix more 'Nerd Font Mono' too wide the glyphs 'ij' and 'IJ' are exempted from the advance width calculation, because some fonts (i.e. Overpass Mono) defines them as two cell wide glyphs (Hello? 'Mono'?) For some obscure reason it was 'IJ' and 'J circumflex' that were exempt, not 'ij'. [how] Exempt correct code. Fixes: ryanoasis#703 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
🗹 Requirements
🎯 Spacing issues in Overpass Nerdfont
When I use Overpass Nerdfont the spacing between letters is mishandled.
🔧 Your Setup
★ Optional
The text was updated successfully, but these errors were encountered: