Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sauce Code Pro Italic Nerd Font Complete (Mono) can't be opened on Windows #1084

Closed
3 tasks done
Jackenmen opened this issue Jan 26, 2023 · 6 comments · Fixed by #1085
Closed
3 tasks done

Sauce Code Pro Italic Nerd Font Complete (Mono) can't be opened on Windows #1084

Jackenmen opened this issue Jan 26, 2023 · 6 comments · Fixed by #1085
Labels
confirmed

Comments

@Jackenmen
Copy link

🗹 Requirements

  • I have searched the issues for my issue and found nothing related and/or helpful
  • I have searched the FAQ for help
  • I have searched the Wiki for help

🎯 Subject of the issue

Experienced behavior:
When trying to open files "Sauce Code Pro Italic Nerd Font Complete Windows Compatible.ttf" and "Sauce Code Pro Italic Nerd Font Complete Mono Windows Compatible.ttf" unpacked from the SourceCodePro.zip in v2.3.3 release, I see an error: "The requested file is not a valid font file.":
image

Expected behavior:
I expect to be able to install these two fonts, the same as I am able to install the other 26 fonts that are part of the SourceCodePro.zip in the v2.3.3 release.

Example symbols:
N/A

🔧 Your Setup

  • Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)?
    • Sauce Code Pro Italic Nerd Font Complete Windows Compatible.ttf
    • Sauce Code Pro Italic Nerd Font Complete Mono Windows Compatible.ttf
  • Where did you get the file from (download link, self patched, source downloaded from link...)
  • Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)?
    • N/A
  • Are you using OS X, Linux or Windows? And which specific version or distribution?
    • Windows 10 22H2 (OS Build 19045.2486)

★ Screenshots (Optional)

image
image
@Jackenmen Jackenmen changed the title Sauce Code Pro Italic Nerd Font Complete (Mono).ttf can't be opened on Windows Sauce Code Pro Italic Nerd Font Complete (Mono) can't be opened on Windows Jan 26, 2023
@Finii
Copy link
Collaborator

Finii commented Jan 27, 2023

All 4 fonts affected of Italic.

@Finii
Copy link
Collaborator

Finii commented Jan 27, 2023

Opens ok in fontforge
https://wakamaifondue.com/beta/ shows metadata but no glyphs.

image

Why do we have two (2) italic versions? All other styles/weights have just one file (as expected):
image
Both source files do open under Windows, though.

@Finii
Copy link
Collaborator

Finii commented Jan 27, 2023

I guess the problem is that we work concurrently on patching both, creating the same one output file and the 'does not blend'.

Where do they come from?

image

Patching both individually (without -j) and testing, both work individually.
So the reason IS the parallel processing of same named font files and tweaking them.

Finii added a commit that referenced this issue Jan 27, 2023
@Finii
SourceCodePro: Remove obsolete font
590c568 
[why]
In the course of #271 the source for SourceCodePro switched: Before we
used SourceCode Powerline [1], afterwards the original one [2].

One font file has been forgotten, as the font files were differently
named in both variants.

This caused issed with parallel build in the CI and font tweaking (which
is done as additional process after the actual patching).

[note]
[1] https://github.com/ryanmcilmoyl/sourceCodePro-Powerline
[2] https://github.com/adobe-fonts/source-code-pro/releases/tag/2.030R-ro%2F1.050R-it

Maybe, this is not entirely clear, and the 'Powerline' variant does not
have an Italic style.

Fixes: #1084

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii mentioned this issue Jan 27, 2023
Merged
2 tasks
Finii added a commit that referenced this issue Jan 27, 2023
@Finii
SourceCodePro: Remove obsolete font
b1439b1 
[why]
In the course of #271 the source for SourceCodePro switched: Before we
used SourceCode Powerline [1], afterwards the original one [2].

One font file has been forgotten, as the font files were differently
named in both variants.

This caused issed with parallel build in the CI and font tweaking (which
is done as additional process after the actual patching).

[note]
[1] https://github.com/ryanmcilmoyl/sourceCodePro-Powerline
[2] https://github.com/adobe-fonts/source-code-pro/releases/tag/2.030R-ro%2F1.050R-it

Maybe, this is not entirely clear, and the 'Powerline' variant does not
have an Italic style.

Fixes: #1084

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Copy link
Collaborator

Finii commented Jan 27, 2023

Fixed:

image

Please find the corrected files here (until the next release at least):

https://github.com/ryanoasis/nerd-fonts/tree/master/patched-fonts/SourceCodePro/Italic/complete

@Finii
Copy link
Collaborator

Finii commented Jan 27, 2023

Thanks for reporting!

@Finii Finii mentioned this issue Mar 5, 2023
Closed
3 tasks
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SourceCodePro: Remove obsolete font ryanoasis/nerd-fonts
2 participants
@Jackenmen @Finii