bug: fixed #39

src/the_well_maintained_test/cli.py

@@ -216,10 +216,7 @@ def package(package: str, branch: str, progress: bool, output: str) -> None:  #
         name (str): The name of the Package from PyPi
     """
     pypi_url = f"https://pypi.org/pypi/{package}/json"
-    project_urls = requests.get(pypi_url).json().get("info").get("project_urls")
-    for _, v in project_urls.items():
-        if urlparse(v).netloc == "github.com" and len(urlparse(v).path.split("/")) == 3:
-            url = v
+    url = _get_package_github_url(package)[1]
 
     "url to a github repository you'd like to check"
     if url[-1] == "/":

src/the_well_maintained_test/helpers.py

@@ -85,4 +85,8 @@ def _get_package_github_url(package: str) -> tuple:
     for k, v in project_urls.items():
         if urlparse(v).netloc == "github.com" and len(urlparse(v).path.split("/")) == 3:
             value = (package, v)
+        elif urlparse(v).netloc == "github.com" and len(urlparse(v).path.split("/")) == 4:
+            p = urlparse(v).path.split("/")[1]
+            a = urlparse(v).path.split("/")[2]
+            value = (package, f"https://www.github.com/{p}/{a}")
     return value

tests/test_classes.py

@@ -447,3 +447,18 @@ def json():
                 }
             }
         }
+
+
+class MockResponseNonGitHubHomePage:
+    @staticmethod
+    def json():
+        return {
+            "info": {
+                "project_urls": {
+                    "CI": "https://github.com/author/package/actions",
+                    "Changelog": "https://github.com/author/package/releases",
+                    "Homepage": "https://www.package.com",
+                    "Issues": "https://github.com/author/package/issues",
+                }
+            }
+        }

tests/test_the_well_maintained_test.py

@@ -33,6 +33,7 @@
     MockResponseFrameworkCheck,
     MockResponseGitHubRateLimit,
     MockResponseLanguageCheck,
+    MockResponseNonGitHubHomePage,
     MockResponseProductionReadyNo,
     MockResponseProductionReadyYes,
     MockResponseProjectURLs,
@@ -48,6 +49,7 @@
 from the_well_maintained_test.cli import cli
 from the_well_maintained_test.helpers import (
     _check_verb_agreement,
+    _get_package_github_url,
     _get_requirements_txt_file,
 )
 from the_well_maintained_test.utils import (
@@ -841,3 +843,14 @@ def mock_get(*args, **kwargs):
     actual = get_vulnerabilities(url)
     expected = 0
     assert actual == expected
+
+
+def test__get_package_github_url_non_github_homepage(monkeypatch):
+    def mock_get(*args, **kwargs):
+        return MockResponseNonGitHubHomePage()
+
+    monkeypatch.setattr(requests, "get", mock_get)
+    url = "https://fakeurl"
+    actual = _get_package_github_url(url)[1]
+    expected = "https://www.github.com/author/package"
+    assert actual == expected