Converted System.out.printlns to logger.errors

rwilliams-r7 · Jun 10, 2016 · d4d9df3 · d4d9df3
1 parent b4e3ef8
commit d4d9df3
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/...java/com/netflix/hystrix/contrib/reactivesocket/serialize/SerialHystrixConfiguration.java b/...java/com/netflix/hystrix/contrib/reactivesocket/serialize/SerialHystrixConfiguration.java
@@ -28,6 +28,8 @@
 import com.netflix.hystrix.config.HystrixConfiguration;
 import com.netflix.hystrix.config.HystrixThreadPoolConfiguration;
 import org.agrona.LangUtil;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;
@@ -38,6 +40,8 @@
 
 public class SerialHystrixConfiguration extends SerialHystrixMetric {
 
+    private static final Logger logger = LoggerFactory.getLogger(SerialHystrixConfiguration.class);
+
     public static byte[] toBytes(HystrixConfiguration config) {
         byte[] retVal = null;
 
@@ -180,7 +184,7 @@ public static HystrixConfiguration fromByteBuffer(ByteBuffer bb) {
                 collapserConfigMap.put(collapserKey, collapserConfig);
             }
         } catch (IOException ioe) {
-            System.out.println("IO Exception : " + ioe);
+            logger.error("IO Exception during deserialization of HystrixConfiguration : " + ioe);
         }
         return new HystrixConfiguration(commandConfigMap, threadPoolConfigMap, collapserConfigMap);
     }

diff --git a/...c/main/java/com/netflix/hystrix/contrib/reactivesocket/serialize/SerialHystrixMetric.java b/...c/main/java/com/netflix/hystrix/contrib/reactivesocket/serialize/SerialHystrixMetric.java
@@ -21,13 +21,16 @@
 import com.fasterxml.jackson.dataformat.cbor.CBORParser;
 import io.reactivesocket.Frame;
 import io.reactivesocket.Payload;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.IOException;
 import java.nio.ByteBuffer;
 
 public class SerialHystrixMetric {
     protected final static CBORFactory cborFactory = new CBORFactory();
     protected final static ObjectMapper mapper = new ObjectMapper();
+    protected final static Logger logger = LoggerFactory.getLogger(SerialHystrixMetric.class);
 
     public static Payload toPayload(byte[] byteArray) {
         return new Payload() {
@@ -53,7 +56,7 @@ public static String fromByteBufferToString(ByteBuffer bb) {
 
             return rootNode.toString();
         } catch (IOException ioe) {
-            System.out.println("IO Exception : " + ioe);
+            logger.error("IO Exception during deserialization of ByteBuffer of Hystrix Metric : " + ioe);
             return "";
         }
     }

diff --git a/...n/java/com/netflix/hystrix/contrib/reactivesocket/serialize/SerialHystrixUtilization.java b/...n/java/com/netflix/hystrix/contrib/reactivesocket/serialize/SerialHystrixUtilization.java
@@ -24,6 +24,8 @@
 import com.netflix.hystrix.metric.sample.HystrixThreadPoolUtilization;
 import com.netflix.hystrix.metric.sample.HystrixUtilization;
 import org.agrona.LangUtil;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;
@@ -34,6 +36,8 @@
 
 public class SerialHystrixUtilization extends SerialHystrixMetric {
 
+    private final static Logger logger = LoggerFactory.getLogger(SerialHystrixUtilization.class);
+
     public static byte[] toBytes(HystrixUtilization utilization) {
         byte[] retVal = null;
 
@@ -103,7 +107,7 @@ public static HystrixUtilization fromByteBuffer(ByteBuffer bb) {
                 threadPoolUtilizationMap.put(threadPoolKey, threadPoolUtilization);
             }
         } catch (IOException ioe) {
-            System.out.println("IO Exception : " + ioe);
+            logger.error("IO Exception during desrialization of HystrixUtilization : " + ioe);
         }
         return new HystrixUtilization(commandUtilizationMap, threadPoolUtilizationMap);
     }