make inner classes static where possible, and remove outer class refe…

…rence

hystrix-contrib/hystrix-metrics-event-stream/src/main/java/com/netflix/hystrix/contrib/metrics/eventstream/HystrixMetricsPoller.java

@@ -509,7 +509,7 @@ public Long call() {
         }
     }
 
-    private class MetricsPollerThreadFactory implements ThreadFactory {
+    private static class MetricsPollerThreadFactory implements ThreadFactory {
         private static final String MetricsThreadName = "HystrixMetricPoller";
 
         private final ThreadFactory defaultFactory = Executors.defaultThreadFactory();

hystrix-core/src/main/java/com/netflix/hystrix/util/HystrixRollingNumber.java

@@ -504,7 +504,7 @@ LongMaxUpdater getMaxUpdater(HystrixRollingNumberEvent type) {
      * <p>
      * benjchristensen => This implementation was chosen based on performance testing I did and documented at: http://benjchristensen.com/2011/10/08/atomiccirculararray/
      */
-    /* package */class BucketCircularArray implements Iterable<Bucket> {
+    /* package */static class BucketCircularArray implements Iterable<Bucket> {
         private final AtomicReference<ListState> state;
         private final int dataLength; // we don't resize, we always stay the same, so remember this
         private final int numBuckets;

hystrix-core/src/main/java/com/netflix/hystrix/util/HystrixRollingPercentile.java

@@ -453,7 +453,7 @@ private int computePercentile(double percent) {
      * <p>
      * benjchristensen => This implementation was chosen based on performance testing I did and documented at: http://benjchristensen.com/2011/10/08/atomiccirculararray/
      */
-    /* package for testing */ class BucketCircularArray implements Iterable<Bucket> {
+    /* package for testing */ static class BucketCircularArray implements Iterable<Bucket> {
         private final AtomicReference<ListState> state;
         private final int dataLength; // we don't resize, we always stay the same, so remember this
         private final int numBuckets;

hystrix-core/src/main/java/com/netflix/hystrix/util/HystrixTimer.java

@@ -107,7 +107,7 @@ public void run() {
         return new TimerReference(listener, f);
     }
 
-    private class TimerReference extends SoftReference<TimerListener> {
+    private static class TimerReference extends SoftReference<TimerListener> {
 
         private final ScheduledFuture<?> f;