Skip to content

Commit

Permalink
Merge pull request #117 from Alexandre-T/dev-php8
Browse files Browse the repository at this point in the history
  • Loading branch information
rvanlaak authored Jun 23, 2021
2 parents 86e0dfb + b82bb4b commit e94a8fa
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 13 deletions.
2 changes: 2 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ matrix:
env: SYMFONY_VERSION=4.3.*
- php: 7.4
env: SYMFONY_VERSION=5.0.*
- php: 8.0
env: SYMFONY_VERSION=5.2.*


install:
Expand Down
6 changes: 4 additions & 2 deletions Manager/SettingsManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
use Dmishh\SettingsBundle\Exception\WrongScopeException;
use Dmishh\SettingsBundle\Serializer\SerializerInterface;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\EntityRepository;
use Doctrine\Persistence\ObjectManager;

/**
* Settings Manager provides settings management and persistence using Doctrine's Object Manager.
Expand All @@ -29,12 +31,12 @@ class SettingsManager implements SettingsManagerInterface
private $ownerSettings;

/**
* @var \Doctrine\Common\Persistence\ObjectManager
* @var ObjectManager
*/
private $em;

/**
* @var \Doctrine\ORM\EntityRepository
* @var EntityRepository<Setting>
*/
private $repository;

Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
}
],
"require": {
"php": "^7.2",
"php": "^7.2|^8.0",
"psr/cache": "^1.0",
"symfony/framework-bundle": "^3.4 || ^4.3 || ^5.0",
"symfony/form": "^3.4 || ^4.3 || ^5.0",
Expand Down
10 changes: 0 additions & 10 deletions phpstan-baseline.neon
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,6 @@ parameters:
count: 1
path: Form/Type/SettingsType.php

-
message: "#^Parameter \\#2 \\$input1 of function array_map expects array, array\\|false given\\.$#"
count: 1
path: Form/Type/SettingsType.php

-
message: "#^Method Dmishh\\\\SettingsBundle\\\\Form\\\\Type\\\\SettingsType\\:\\:configureOptions\\(\\) has no return typehint specified\\.$#"
count: 1
Expand Down Expand Up @@ -150,11 +145,6 @@ parameters:
count: 1
path: Manager/SettingsManager.php

-
message: "#^Property Dmishh\\\\SettingsBundle\\\\Manager\\\\SettingsManager\\:\\:\\$repository \\(Doctrine\\\\ORM\\\\EntityRepository\\) does not accept Doctrine\\\\Persistence\\\\ObjectRepository\\.$#"
count: 1
path: Manager/SettingsManager.php

-
message: "#^Method Dmishh\\\\SettingsBundle\\\\Manager\\\\SettingsManager\\:\\:get\\(\\) has no return typehint specified\\.$#"
count: 1
Expand Down

0 comments on commit e94a8fa

Please sign in to comment.