Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider lightweight tags in GixBuilder::describe() based on tags #364

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Consider lightweight tags in GixBuilder::describe() based on tags #364

merged 2 commits into from
Aug 14, 2024

Conversation

SanchithHegde
Copy link
Contributor

This PR updates the vergen-gix crate to consider lightweight tags in a git repository when emitting the describe output, depending on the value of the tags parameter provided. This fixes the issue reported in #359 (comment). This PR also updates the test repo creation code to create a lightweight tag, and adds a test case in the vergen-gix crate.

While working on this PR, I noticed that the vergen-gix crate does not consider the matches parameter, I've opened #363 so that it's documented for other users of the crate.

@SanchithHegde
Copy link
Contributor Author

@CraZySacX Should I worry about the failing code coverage tests? I don't see any commands being run for the code coverage step, since the configuration variable being read in the workflow file (VERGEN_RUN_CMD) is not available in my fork.

@CraZySacX
Copy link
Member

@CraZySacX Should I worry about the failing code coverage tests? I don't see any commands being run for the code coverage step, since the configuration variable being read in the workflow file (VERGEN_RUN_CMD) is not available in my fork.

No, it's not your fault. I moved to re-usable workflows to support all of my rust projects and they don't allow forks to read environment variables. The coverage workflow depends on a couple and fails in forks because they are empty. I'm still trying to figure out the best way to handle it.

@CraZySacX CraZySacX merged commit b2c70c7 into rustyhorde:master Aug 14, 2024
24 of 28 checks passed
@SanchithHegde SanchithHegde deleted the vergen-gix-consider-lightweight-tags branch August 14, 2024 13:12
@SanchithHegde
Copy link
Contributor Author

@CraZySacX If it isn't asking for too much, could you please release vergen-gix v1.0.1 with this fix? We were thinking of migrating one of our repos from vergen-git2 to vergen-gix, and describe is the only aspect where the output of vergen-gix differs.

@CraZySacX
Copy link
Member

Yep, will get this out today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants