Suppress useless warnings #1308
Conversation
admin/tests/acceptance.rs
Outdated
| @@ -1,4 +1,4 @@ | |||
| #![deny(warnings, missing_docs, trivial_casts, unused_qualifications)] | |||
| #![deny(rivial_casts, unused_qualifications)] | |||
There was a problem hiding this comment.
| #![deny(rivial_casts, unused_qualifications)] | |
| #![deny(trivial_casts, unused_qualifications)] |
We can probably also relax these to warn, but do -D warnings in CI
There was a problem hiding this comment.
Yeah, I agree we should get rid of deny(warnings) everywhere and use RUSTFLAGS='-D warnings' on CI. That's orthogonal to this PR though - here I'm just relaxing the rules for rustsec-admin acceptance tests.
|
Well, now that I've merged it, CI started failing. How come did it work on this branch but not after merging? I'm done with this for today. Ugh. |
|
It looks like CI never actually passed? We need a dependency upgrade PR like #1307 to clear the self-audit |
|
Self-audit never passed but all the tests did. And then the tests failed on main somehow. |
|
The “happy path” test includes a self-audit |
|
🤦 Okay, that explains it. Thank you. |
Unblocks development.
These are problematic both due to
deny(warnings)and the sheer amount of times they're emitted, drowning out all the actually useful warnings.