Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tiny-http Request Smuggling #355

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Add tiny-http Request Smuggling #355

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7233ee
Add tiny-http Request Smuggling
snoopysecurity Aug 21, 2020
1400f85
drop categories
Shnatsel Aug 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions crates/tiny_http/RUSTSEC-2020-0000.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
[advisory]
id = "RUSTSEC-2020-0000"
package = "tiny_http"
date = "2020-06-16"
title = "HTTP Request smuggling through malformed Transfer Encoding headers"
url = "https://github.com/tiny-http/tiny-http/issues/173"
categories = ["format-injection"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think "format injection" is quite correct; we do not seem to have a proper category for this.

I suppose we should eventually transition to CWE, but in the meanwhile it's probably best to just drop the category field here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah agreed, this is an injection vulnerability, but the format-injection category is more precisely intended for "format string injection" vulnerabilities.

Also agreed it'd be nice to implement CWE.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, CWE would be nice

keywords = ["http", "request-smuggling"]
description = """
HTTP pipelining issues and request smuggling attacks are possible due to incorrect
Transfer encoding header parsing.

It is possible conduct HTTP request smuggling attacks (CL:TE/TE:TE) by sending invalid Transfer Encoding headers.

By manipulating the HTTP response the attacker could poison a web-cache, perform an XSS attack, or obtain sensitive information
from requests other than their own.
"""

[versions]
patched = []