-
Notifications
You must be signed in to change notification settings - Fork 377
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add rustsec advisory for GHSA-v666-6w97-pcwm (#1015)
* Add rustsec advisory for GHSA-v666-6w97-pcwm * Update RUSTSEC-0000-0000.md Co-authored-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
- Loading branch information
Showing
1 changed file
with
34 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
```toml | ||
[advisory] | ||
id = "RUSTSEC-0000-0000" | ||
package = "ckb" | ||
date = "2021-07-25" | ||
url = "https://github.com/nervosnetwork/ckb/security/advisories/GHSA-v666-6w97-pcwm" | ||
aliases = ["GHSA-v666-6w97-pcwm"] | ||
[versions] | ||
patched = [">= 0.40.0"] | ||
``` | ||
|
||
# Miner fails to get block template when a cell used as a cell dep has been destroyed. | ||
|
||
## Impact | ||
|
||
The RPC get_block_template fails when a cell has been used as a cell dep and an input in the different transactions. | ||
|
||
Say cell C is used as a dep group in the transaction A, and is destroyed in the transaction B. | ||
|
||
The node adds transaction A first, then B into the transaction pool. They are both valid. But when generating the block template, if the fee rate of B is higher, it comes before A, which will invalidate A. Currently the RPC get_block_template will fail instead of dropping A. | ||
|
||
## Patch | ||
|
||
First, the get_block_template should not fail but dropping the conflict transactions. | ||
|
||
Then we can propose solution to this issue. Here is an example. When a transaction is added to the pool, the pool must consider it depending on all the transactions which dep cell (direct or indirect via dep group) has been destroyed in this transaction. Because future transactions using the destroyed cells as dep will be rejected, the spending transaction only need to wait for all the existing dep transactions on chain. | ||
|
||
## Workaround | ||
|
||
Submit transaction B when A is already on chain. | ||
Let B depend on A explicitly, there are several solutions: | ||
a. Add any output cell on A as a dep cell or input in B. | ||
b. Merge A and B. CKB allows using the same cell as both dep and input in the same transaction. | ||
Ensure the fee rate of B is less than A so A always has higher priority. |