Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cert: fix clippy get_first finding #220

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Conversation

cpu
Copy link
Member

@cpu cpu commented Dec 29, 2023

Scheduled CI tasks started failing yesterday with the update to the just-released Rust 1.75 from a clippy finding:

error: accessing first element with `crl_distribution_points.get(0)`
   --> src/cert.rs:620:13
    |
620 | /             crl_distribution_points
621 | |                 .get(0)
    | |_______________________^ help: try: `crl_distribution_points.first()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
    = note: `-D clippy::get-first` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::get_first)]`

```
error: accessing first element with `crl_distribution_points.get(0)`
   --> src/cert.rs:620:13
    |
620 | /             crl_distribution_points
621 | |                 .get(0)
    | |_______________________^ help: try: `crl_distribution_points.first()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
    = note: `-D clippy::get-first` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::get_first)]`
```
@cpu cpu self-assigned this Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b528297) 97.16% compared to head (e98d948) 97.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files          19       19           
  Lines        4303     4303           
=======================================
  Hits         4181     4181           
  Misses        122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djc djc added this pull request to the merge queue Dec 29, 2023
Merged via the queue into rustls:main with commit 4a80225 Dec 29, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants