Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some new 1.79 clippy findings #50

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Fix some new 1.79 clippy findings #50

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49d1ea4
server_name: fix clippy::missing_transmute_annotations
cpu Jun 14, 2024
f6ea944
server_name: fix clippy::use_self findings
cpu Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/server_name.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ pub struct DnsName<'a>(DnsNameInner<'a>);

impl<'a> DnsName<'a> {
/// Produce a borrowed `DnsName` from this owned `DnsName`.
pub fn borrow(&'a self) -> DnsName<'_> {
pub fn borrow(&'a self) -> Self {
Self(match self {
Self(DnsNameInner::Borrowed(s)) => DnsNameInner::Borrowed(s),
#[cfg(feature = "alloc")]
Expand Down Expand Up @@ -179,7 +179,7 @@ impl TryFrom<String> for DnsName<'static> {
impl<'a> TryFrom<&'a str> for DnsName<'a> {
type Error = InvalidDnsNameError;

fn try_from(value: &'a str) -> Result<DnsName<'a>, Self::Error> {
fn try_from(value: &'a str) -> Result<Self, Self::Error> {
validate(value.as_bytes())?;
Ok(Self(DnsNameInner::Borrowed(value)))
}
Expand All @@ -188,7 +188,7 @@ impl<'a> TryFrom<&'a str> for DnsName<'a> {
impl<'a> TryFrom<&'a [u8]> for DnsName<'a> {
type Error = InvalidDnsNameError;

fn try_from(value: &'a [u8]) -> Result<DnsName<'a>, Self::Error> {
fn try_from(value: &'a [u8]) -> Result<Self, Self::Error> {
validate(value)?;
Ok(Self(DnsNameInner::Borrowed(str::from_utf8(value).unwrap())))
}
Expand All @@ -211,8 +211,8 @@ enum DnsNameInner<'a> {
Owned(String),
}

impl<'a> PartialEq<DnsNameInner<'a>> for DnsNameInner<'a> {
fn eq(&self, other: &DnsNameInner<'a>) -> bool {
impl<'a> PartialEq<Self> for DnsNameInner<'a> {
fn eq(&self, other: &Self) -> bool {
match (self, other) {
(Self::Borrowed(s), Self::Borrowed(o)) => s.eq_ignore_ascii_case(o),
#[cfg(feature = "alloc")]
Expand Down Expand Up @@ -442,7 +442,7 @@ impl From<[u16; 8]> for Ipv6Addr {
Self(
// All elements in `addr16` are big endian.
// SAFETY: `[u16; 8]` is always safe to transmute to `[u8; 16]`.
unsafe { mem::transmute::<_, [u8; 16]>(addr16) },
unsafe { mem::transmute::<[u16; 8], [u8; 16]>(addr16) },
)
}
}
Expand Down Expand Up @@ -479,7 +479,7 @@ mod parser {
}

impl<'a> Parser<'a> {
pub(super) fn new(input: &'a [u8]) -> Parser<'a> {
pub(super) fn new(input: &'a [u8]) -> Self {
Parser { state: input }
}

Expand Down
Loading