Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config)!: use multiple options only as array in config profile #1240

Merged
merged 9 commits into from
Sep 23, 2024
Merged

fix(config)!: use multiple options only as array in config profile #1240

merged 9 commits into from
Sep 23, 2024

Conversation

aawsome
Copy link
Member

@aawsome aawsome commented Sep 16, 2024 •
edited
Loading

Consistently uses singular and plural names for options in config and CLI

BREAKING CHANGE: This requires to adapt CLI calls and config keys.

Affected options:

  • glob -> globs in config profile
  • iglob -> iglobs in config profile
  • glob-file -> glob-files in config profile
  • iglob-file -> iglob-files in config profile
  • custom-ignore-file -> custom-ignore-files in config profile
  • tag-> tags in config profile
  • keep-tags -> now only array
  • keep-ids -> now only array
  • use-profile-> use-profiles in config profile
  • backup.sources -> backup.snapshots in config profile
  • filter-host -> filter-hosts in config profile
  • filter-label -> filter-labels in config profile

@simonsan simonsan changed the title fix!: use multiple options only as array in config profile fix(config)!: use multiple options only as array in config profile Sep 18, 2024
@simonsan simonsan added the A-config Area: Related to the config file functionality and format label Sep 18, 2024
@simonsan simonsan added the S-blocked Status: Blocked from merging/working on due to some issue label Sep 18, 2024
@aawsome aawsome mentioned this pull request Sep 21, 2024
Merged
@aawsome aawsome removed the S-blocked Status: Blocked from merging/working on due to some issue label Sep 22, 2024
@aawsome aawsome added the S-blocked Status: Blocked from merging/working on due to some issue label Sep 22, 2024
@aawsome aawsome mentioned this pull request Sep 22, 2024
Merged
@aawsome aawsome removed the S-blocked Status: Blocked from merging/working on due to some issue label Sep 23, 2024
@simonsan simonsan added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 86fa855 Sep 23, 2024
25 checks passed
@simonsan simonsan deleted the plural-options branch September 23, 2024 15:23
@rustic-release-plz rustic-release-plz bot mentioned this pull request Sep 24, 2024
Merged
simonsan pushed a commit that referenced this pull request Sep 29, 2024
@rustic-release-plz @aawsome
chore: release v0.9.0 (#1256)
ee3f099 
## 🤖 New release
* `rustic-rs`: 0.8.1 -> 0.9.0 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.9.0](v0.8.1...v0.9.0)
- 2024-09-29

### Added

- *(commands)* Add list indexpacks and list indexcontent commands
([#1254](#1254))
- *(commands)* Add option `--only-identical` for `diff` to allow for
bitrot check ([#1250](#1250))
- *(commands)* ls: Add option --json
([#1251](#1251))
- *(commands)* [**breaking**] copy: Use config profile as target
([#1131](#1131))
- *(commands)* backup: Add option --long
([#1159](#1159))

### Fixed

- *(deps)* update rust crate libc to v0.2.159
([#1257](#1257))
- *(config)* [**breaking**] use multiple options only as array in config
profile ([#1240](#1240))
- *(interactive)* Allow snapshots to be modified and marked to forget
([#1253](#1253))
- make ls and find show the year of mtime date
([#1249](#1249))
- ls: Remove printing trailing space
([#1247](#1247))
- webdav/forget: correctly use application config
([#1241](#1241))

### Other

- update installation instructions in readme to use `--locked` flag for
install from crates.io
- *(deps)* lock file maintenance
([#1269](#1269))
- delete unused xtask pattern directory
- *(deps)* update rust crate rstest to 0.23
([#1267](#1267))
- *(deps)* update rust crate tempfile to v3.13.0
([#1266](#1266))
- *(deps)* update marcoieni/release-plz-action digest to 8b0f89a
([#1265](#1265))
- *(deps)* update embarkstudios/cargo-deny-action action to v2
([#1259](#1259))
- *(deps)* update rustsec/audit-check action to v2
([#1260](#1260))
- *(deps)* update softprops/action-gh-release action to v2
([#1258](#1258))
- *(deps)* update embarkstudios/cargo-deny-action digest to 3f4a782
([#1228](#1228))
- don't let release-plz create GH releases
- exclude the CHANGELOG from dprint formatting
- remove `-dev` description from version for release-plz to work
- remove release-pr workflow and replace with release-plz
- *(cd)* try fixing nightly release pipeline
- *(deps)* Update to new releases
([#1255](#1255))
- Reduce memory usage of restore
([#1069](#1069))
- Update to newest rustic_core
([#1248](#1248))
- update RepositoryErrorKind rustdoc following rustic_core change
([#1237](#1237))
- set development version
- add flag for building with self-update feature for nightly and CD
- Remove self-update from default crate features
([#1139](#1139))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: rustic-release-plz[bot] <182542030+rustic-release-plz[bot]@users.noreply.github.com>
Co-authored-by: Alexander Weiss <alex@weissfam.de>
@serkonda7 serkonda7 mentioned this pull request Oct 1, 2024
Closed
simonsan pushed a commit that referenced this pull request Oct 2, 2024
@rustic-release-plz @aawsome @simonsan
chore: release v0.9.0 (#1256)
1ad9ee9 
## 🤖 New release
* `rustic-rs`: 0.8.1 -> 0.9.0 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.9.0](v0.8.1...v0.9.0)
- 2024-09-29

### Added

- *(commands)* Add list indexpacks and list indexcontent commands
([#1254](#1254))
- *(commands)* Add option `--only-identical` for `diff` to allow for
bitrot check ([#1250](#1250))
- *(commands)* ls: Add option --json
([#1251](#1251))
- *(commands)* [**breaking**] copy: Use config profile as target
([#1131](#1131))
- *(commands)* backup: Add option --long
([#1159](#1159))

### Fixed

- *(deps)* update rust crate libc to v0.2.159
([#1257](#1257))
- *(config)* [**breaking**] use multiple options only as array in config
profile ([#1240](#1240))
- *(interactive)* Allow snapshots to be modified and marked to forget
([#1253](#1253))
- make ls and find show the year of mtime date
([#1249](#1249))
- ls: Remove printing trailing space
([#1247](#1247))
- webdav/forget: correctly use application config
([#1241](#1241))

### Other

- update installation instructions in readme to use `--locked` flag for
install from crates.io
- *(deps)* lock file maintenance
([#1269](#1269))
- delete unused xtask pattern directory
- *(deps)* update rust crate rstest to 0.23
([#1267](#1267))
- *(deps)* update rust crate tempfile to v3.13.0
([#1266](#1266))
- *(deps)* update marcoieni/release-plz-action digest to 8b0f89a
([#1265](#1265))
- *(deps)* update embarkstudios/cargo-deny-action action to v2
([#1259](#1259))
- *(deps)* update rustsec/audit-check action to v2
([#1260](#1260))
- *(deps)* update softprops/action-gh-release action to v2
([#1258](#1258))
- *(deps)* update embarkstudios/cargo-deny-action digest to 3f4a782
([#1228](#1228))
- don't let release-plz create GH releases
- exclude the CHANGELOG from dprint formatting
- remove `-dev` description from version for release-plz to work
- remove release-pr workflow and replace with release-plz
- *(cd)* try fixing nightly release pipeline
- *(deps)* Update to new releases
([#1255](#1255))
- Reduce memory usage of restore
([#1069](#1069))
- Update to newest rustic_core
([#1248](#1248))
- update RepositoryErrorKind rustdoc following rustic_core change
([#1237](#1237))
- set development version
- add flag for building with self-update feature for nightly and CD
- Remove self-update from default crate features
([#1139](#1139))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: rustic-release-plz[bot] <182542030+rustic-release-plz[bot]@users.noreply.github.com>
Co-authored-by: Alexander Weiss <alex@weissfam.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsan simonsan simonsan approved these changes

Assignees
No one assigned
Labels
A-config Area: Related to the config file functionality and format
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aawsome @simonsan