Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.9.2 breaks prune operations #1313

Closed
kapitainsky opened this issue Oct 9, 2024 · 2 comments
Closed

v0.9.2 breaks prune operations #1313

kapitainsky opened this issue Oct 9, 2024 · 2 comments
Labels
A-core Area: Generally related to `rustic_core` C-bug Category: Something isn't working as expected P-high Priority: High, to be fixed at a higher priority

Comments

@kapitainsky
Copy link
Contributor

When attempting to run prune:

$ rustic prune --instant-delete --max-unused 0% --max-repack=1GB

the following panic occurs:

$ cat /var/folders/36/02d6s6313zq5k3mfrhg4d8zc0000gn/T/report-f060cace-32eb-49a6-9b9f-fff65db481be.toml
name = "rustic-rs"
operating_system = "Mac OS 15.0.1 [64-bit]"
crate_version = "0.9.2"
explanation = """
Panic occurred in file '/Users/kptsky/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rustic_core-0.5.2/src/blob/tree.rs' at line 698
"""
cause = """

                        Sending tree bc967136 on channel failed: sending on a full channel.

                        This should not happen! Please report it to the developers: https://github.com/rustic-rs/rustic_core/issues/new
                        """
method = "Panic"
backtrace = """

   0: 0x10a201e3a - __mh_execute_header
   1: 0x109d45aab - __mh_execute_header
   2: 0x109d437d4 - __mh_execute_header
   3: 0x10a0726ab - __mh_execute_header
   4: 0x7ff81a603253 - __pthread_start"""

It happens when rustic is searching for used blobs:

[00:00:00] finding used blobs...          ░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░          0/36

reverting back to v0.9.1 solves the issue
@github-actions github-actions bot added the S-triage Status: Waiting for a maintainer to triage this issue/PR label Oct 9, 2024
@amorison
Copy link

amorison commented Oct 9, 2024

The same error also occurs on rustic check, during the checking trees... step.

name = "rustic-rs"
operating_system = "Arch Linux [64-bit]"
crate_version = "0.9.2"
explanation = """
Panic occurred in file '/build/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rustic_core-0.5.2/src/blob/tree.rs' at line 698
"""
cause = """

                        Sending tree ac08ce34 on channel failed: sending on a full channel. 
                        
                        This should not happen! Please report it to the developers: https://github.com/rustic-rs/rustic_core/issues/new
                        """
method = "Panic"
backtrace = """

   0: 0x590b781be684 - <unresolved>
   1: 0x590b784da61b - <unresolved>
   2: 0x7abefa9f639d - <unresolved>
   3: 0x7abefaa7b49c - <unresolved>
   4:        0x0 - <unresolved>"""

@simonsan simonsan added C-bug Category: Something isn't working as expected A-core Area: Generally related to `rustic_core` P-high Priority: High, to be fixed at a higher priority and removed S-triage Status: Waiting for a maintainer to triage this issue/PR labels Oct 10, 2024
@simonsan simonsan mentioned this issue Oct 10, 2024
Merged
simonsan added a commit to rustic-rs/rustic_core that referenced this issue Oct 10, 2024
@simonsan
Revert "refactor(errors): improve message and add logging when sendin…
81c127e 
…g tree from backend panics" (#325)

Reverts #314
Related rustic-rs/rustic#1313
simonsan added a commit that referenced this issue Oct 10, 2024
@simonsan
fix(deps): update rustic_core to version 0.5.3
929defd 
This contains an immediate fix for a newly introduced bug in 0.5.2 that involved how the TreeStreamerOnce handled errors when a channel was full.

Fixes v0.9.2 breaks prune operations #1313

Signed-off-by: simonsan <14062932+simonsan@users.noreply.github.com>
@simonsan simonsan mentioned this issue Oct 10, 2024
Merged
simonsan added a commit that referenced this issue Oct 10, 2024
@simonsan
fix(deps): update rustic_core to version 0.5.3 (#1314)
facfb2d 
This contains an immediate fix for a newly introduced bug in
`rustic_core v0.5.2` that involved how the `TreeStreamerOnce` handled
errors when a channel was full.

Fixes v0.9.2 breaks prune operations #1313

Signed-off-by: simonsan <14062932+simonsan@users.noreply.github.com>
@simonsan
Copy link
Contributor

Thanks for bringing it up! This is fixed in rustic v0.9.3!

@simonsan simonsan mentioned this issue Oct 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-core Area: Generally related to `rustic_core` C-bug Category: Something isn't working as expected P-high Priority: High, to be fixed at a higher priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amorison @simonsan @kapitainsky