Use compile_env for compile-time configuration #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also deprecate rustler_crates since that cannot be as efficiently tracked by the Elixir compiler.
josevalim
commented
Jun 27, 2023
|
Could you please update the "UPDATE.md" and changelog as well? |
|
Done. |
|
I am preparing a point-release to get the Elixir 1.15 changes out before my vacation, I take it this one would not need to be included, right? |
|
@filmor no need, yeah. :) |
filmor
reviewed
Sep 24, 2023
| ) | ||
|
|
||
| [] | ||
| end |
There was a problem hiding this comment.
@josevalim Am I misunderstanding something or is this logic the wrong way round? We should raise the warning if :rustler_crates is found, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also deprecate rustler_crates since that cannot be as efficiently tracked by the Elixir compiler.