Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disambiguate encode and decode #466

Merged
merged 3 commits into from
Jun 21, 2022
Merged

Disambiguate encode and decode #466

merged 3 commits into from
Jun 21, 2022

Conversation

SeokminHong
Copy link
Contributor

Since encode and decode are very common names, if any traits have those names that exist, the compiler complains about its ambiguity.

@evnu evnu requested a review from a team June 21, 2022 07:08
filmor
filmor approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@filmor filmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good idea, thanks!

@evnu evnu merged commit 080f1ab into rusterlium:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filmor filmor filmor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SeokminHong @filmor @evnu