Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: Allow breaking convention to avoid breaking change #366

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

evnu
Copy link
Member

@evnu evnu commented Jun 18, 2021

This PR disables clippy::wrong-self-convention for two public functions:

error: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value
   --> rustler/src/types/binary.rs:245:21
    |
245 |     pub fn to_owned(&self) -> Option<OwnedBinary> {
    |                     ^^^^^
    |
    = note: `-D clippy::wrong-self-convention` implied by `-D warnings`
    = help: consider choosing a less ambiguous name
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention

@evnu evnu requested a review from a team June 18, 2021 07:50
@evnu evnu merged commit b051d09 into rusterlium:master Jun 21, 2021
@evnu evnu deleted the fix-clippy branch June 21, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants