Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #334

Merged
merged 3 commits into from
Nov 3, 2020
Merged

Fix warnings #334

merged 3 commits into from
Nov 3, 2020

Conversation

thiamsantos
Copy link
Contributor

@thiamsantos thiamsantos commented Oct 21, 2020

Motivation

In elixir 1.11 I'm getting the following compile warnings during rustler compilation.

==> rustler
Compiling 5 files (.ex)
warning: EEx.eval_string/3 defined in application :eex is used by the current application but the current application does not directly depend on :eex. To fix this, you must
do one of:

  1. If :eex is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :eex is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :eex, you may optionally skip this warning by adding [xref: [exclude: EEx]] to your "def project" in mix.exs

  lib/mix/tasks/rustler.new.ex:79: Mix.Tasks.Rustler.New.copy_from/3

warning: Toml.decode!/1 defined in application :toml is used by the current application but the current application does not directly depend on :toml. To fix this, you must d
o one of:

  1. If :toml is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :toml is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :toml, you may optionally skip this warning by adding [xref: [exclude: Toml]] to your "def project" in mix.exs

  lib/mix/tasks/compile.rustler.ex:177: Mix.Tasks.Compile.Rustler.check_crate_env/1

Proposed Solution

@evnu
Copy link
Member

evnu commented Nov 3, 2020

Thank you for the pull request! Can you re-add Elixir v1.11 to CI? It should be available by now I think (here)

@thiamsantos
Copy link
Contributor Author

@evnu Sure, I force pushed the CI for 1.11

@evnu evnu merged commit c382223 into rusterlium:master Nov 3, 2020
@evnu
Copy link
Member

evnu commented Nov 3, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants