ci: Test OTP 23 #325
Merged
ci: Test OTP 23 #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As #324 is caused by an upstream bug, we might have to wait until the OTP fix is released before merging this change here. |
evnu
commented
Jul 2, 2020
.github/workflows/main.yml
Outdated
| @@ -138,6 +138,9 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| pair: | |||
| - erlang: "23.0.2" | |||
There was a problem hiding this comment.
I tried to use 23.x here, but setup-elixir was not able to convert that into an actual version.
There was a problem hiding this comment.
I changed it back to 23.x, we should somehow make this work instead of pinning the patch version.
filmor
approved these changes
Jul 21, 2020
|
@filmor I added an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hazardfn found that NIF loading sometimes fails, see #324. We should also test against OTP 23.