Fix replacing rustler version in release script #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On a related note, we might want to start tagging releases. With that, we could use the tag for the source_url_pattern:
"https://github.com/rusterlium/rustler/blob/A_VERSION_TAG/rustler_mix/%{path}#L%{line}"That way, source links in the released Elixir documentation on hex.pm will remain useful even if the files change on master. |
Yes! This is something that I want to start doing in the next release. Along with adding the changes from the changelog as release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mix formatin #253 broke changing the rustler version inrustler_mix/mix.exsdone byrelease.sh(here).