Refactor codegen #251
Merged
Refactor codegen #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
751cb11 to
84f3523
Compare
|
Rebased on master. @filmor do you want to give this PR a glance as well? |
|
I'll do that tonight, from a quick glance I only think you could drop the repeated |
filmor
reviewed
Oct 17, 2019
|
The rest looks good to me. |
84f3523 to
5b74eff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proc-macro code generation has a lot of duplicate code over multiple modules. This merge request refactors the modules by pulling common code into the
rustler_codegen::context::Contextstruct and its functions. This is in part as a preparation for #241 in order to simplify de-duplicating thefield_atoms.