Windows: Fix panic when calling set_fullscreen(None) #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build and tested with Windows 7 (64bit) |
francesca64
suggested changes
May 7, 2018
CHANGELOG.md
Outdated
| @@ -16,6 +16,7 @@ | |||
| - On X11, drag and drop now works reliably in release mode. | |||
| - Added `WindowBuilderExt::with_resize_increments` and `WindowBuilderExt::with_base_size` to X11, allowing for more optional hints to be set. | |||
| - Rework of the wayland backend, migrating it to use [Smithay's Client Toolkit](https://github.com/Smithay/client-toolkit). | |||
| - Fix panic when trying to call `set_fullscreen(None)` on a window that has not been fullscreened prior. | |||
There was a problem hiding this comment.
You need to specify which platform this is for.
There was a problem hiding this comment.
(...and don't forget to rebase.)
francesca64
approved these changes
May 7, 2018
added 2 commits
May 8, 2018 01:49
* Add condition to prevent panic Trying to call set_fullscreen(None) on a window that has never been in fullscreen mode caused a panic before this change. The responsible method now simply checks if this precondition is met and returns (does nothing) otherwise. * Add entry to CHANGELOG
Forgot to add that the to_fullscreen(None) bugfix is Windows only in CHANGELOG.
|
Alright, I still want @edwin0cheng to verify that this is good, but then we should be good to merge. Thanks for the contribution! |
Merged
|
Look good to me, and i tested it, it works properly, |
|
@edwin0cheng thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #501
This circumvents a panic when one calls set_fullscreen(None) on a window that has never been in fullscreen mode prior to calling that method.