-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS: Emit resize on frame_did_change #2239
Merged
kchibisov
merged 1 commit into
rust-windowing:master
from
sshock:plh/emit-resize-on-frame-did-change
May 23, 2022
Merged
macOS: Emit resize on frame_did_change #2239
kchibisov
merged 1 commit into
rust-windowing:master
from
sshock:plh/emit-resize-on-frame-did-change
May 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchibisov
reviewed
Apr 4, 2022
kchibisov
requested changes
Apr 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should also add a changelog entry for that change.
Done! |
kchibisov
requested changes
Apr 4, 2022
kchibisov
approved these changes
Apr 4, 2022
When the window switches mode from normal to tabbed one, it doesn't get resized, however the frame gets resized. This commit makes winit to track resizes when frame changes instead of window. Fixes rust-windowing#2191.
457e50d
to
b3ac938
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md
if knowledge of this change could be valuable to usersFor testing:
println!("emitting resize event with size = {:?}", size);
emit_resize_event
method in src/platform_impl/macos/window_delegate.rs.frame_did_change
method in src/platform_impl/macos/view.rs. (next to new code)multiwindow
example program.